File upload

bex · January 8th, 2009, 04:08 AM

hi there i have this code

Code:

ProtectedSub Button1_Click(ByVal sender AsObject, ByVal e As System.EventArgs) Handles btnUpload.Click
If FileUpload1.HasFile Then
Try
FileUpload1.SaveAs("C:\test" & _
FileUpload1.FileName)
Catch ex As Exception
FileUploadReport.Text = "Faild Because:<br/>" & ex.Message
EndTry
FileUploadReport.Text = "File uploaded : <br/>" & FileUpload1.PostedFile.FileName
Else
FileUploadReport.Text = "Please select a file before clicking" & " the 'Upload' button"
EndIf

i need to add an exeption that if file exsists in the directory lbl1.text="file exsists try onother"

Yamini · January 8th, 2009, 08:35 AM

how abt this:

Code:

 if (!Directory.Exists(path))         {             Directory.CreateDirectory(path);         }         else         {             if (!File.Exists(path))             {...// u create the file save it hereon        else             {                 Response.Write("");             }

..if a directory has already been created it chks if the path xsits ..it self xplanatory..

alliancejhall · January 8th, 2009, 10:55 AM

something like?

Code:

    Protected Sub Button1_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles btnUpload.Click

        If FileUpload1.HasFile Then
            Try
                If System.IO.File.Exists("C:\test\" & FileUpload1.FileName) Then
                    lbl1.text = "file exsists try another"
                Else
                    FileUpload1.SaveAs("C:\test" & _
                    FileUpload1.FileName)
                End If
            Catch ex As Exception
                FileUploadReport.Text = "Faild Because:<br/>" & ex.Message
            End Try
                FileUploadReport.Text = "File uploaded : <br/>" & FileUpload1.PostedFile.FileName
        Else
            FileUploadReport.Text = "Please select a file before clicking" & " the 'Upload' button"
        End If

    End Sub

bex · January 8th, 2009, 05:33 PM

it is not working it does not give me an error but the lbl1.text = "file exsists try another"
does not work,
when i try to upload the same file i sr this
FileUploadReport.Text = "File uploaded : <br/>" & FileUpload1.PostedFile.FileName

alliancejhall · January 8th, 2009, 08:28 PM

Are you adding test to the beginning of the file name when saving it or are you trying to add the file to the test directory under c:\ ?

if you are adding test to the file name then change my code to be this...

If System.IO.File.Exists("C:\test" & FileUpload1.PostedFile.FileName) Then

otherwise

If System.IO.File.Exists("C:\test\" & FileUpload1.PostedFile.FileName) Then

should work?

bex · January 9th, 2009, 03:39 AM

No I am not adding test to the filename i just want to upload it under test directory under c:\
the actual code is like this:

Code:

ProtectedSub Button1_Click(ByVal sender AsObject, ByVal e As System.EventArgs) Handles btnUpload.Click
If FileUpload1.HasFile Then
Try
If System.IO.File.Exists("C:\test\" & FileUpload1.FileName) Then
FileUploadReport.Text = "file exsists try another"
Else
FileUpload1.SaveAs("C:\test\" & FileUpload1.FileName)
EndIf
Catch ex As Exception
FileUploadReport.Text = "Faild Because:<br/>" & ex.Message
EndTry
FileUploadReport.Text = "File uploaded : <br/>" & FileUpload1.PostedFile.FileName
Else
FileUploadReport.Text = "Please select a file before clicking" & " the 'Upload' button"
EndIf

bex · January 9th, 2009, 03:44 AM

No I am not adding test to the filename i just want to upload it under test directory under c:\
the actual code is like this:

Code:

ProtectedSub Button1_Click(ByVal sender AsObject, ByVal e As System.EventArgs) Handles btnUpload.Click
If FileUpload1.HasFile Then
Try
If System.IO.File.Exists("C:\test\" & FileUpload1.FileName) Then
FileUploadReport.Text = "file exsists try another"
Else
FileUpload1.SaveAs("C:\test\" & FileUpload1.FileName)
EndIf
Catch ex As Exception
FileUploadReport.Text = "Faild Because:<br/>" & ex.Message
EndTry
FileUploadReport.Text = "File uploaded : <br/>" & FileUpload1.PostedFile.FileName
Else
FileUploadReport.Text = "Please select a file before clicking" & " the 'Upload' button"
EndIf

But i do upload the file to a sql database, does that make any diference?
cos every time i click the upload button the database is updated and multiple file names exsist in the table, i need an exeption for that too?

alliancejhall · January 9th, 2009, 09:39 AM

I am assuming that by uploading to the database you mean you are storing info about the file to the database and not the actual file in binary. If that's the case (either way really) it doesn't matter how many times the file name occurs in the database because you aren't checking the file name in the database you are checking the file exists in the test directory. But i realized what I did wrong. I've tested this code and it works....

Code:

        If FileUpload1.HasFile Then
            Try
                If System.IO.File.Exists("C:\test\" & System.IO.Path.GetFileName(FileUpload1.PostedFile.FileName)) = True Then
                    FileUploadReport.Text = "file exsists try another"
                    Exit Sub
                Else
                    FileUpload1.SaveAs("C:\test\" & System.IO.Path.GetFileName(FileUpload1.PostedFile.FileName))
                End If
            Catch ex As Exception
                FileUploadReport.Text = "Faild Because:<br/>" & ex.Message
            End Try
            FileUploadReport.Text = "File uploaded : <br/>" & FileUpload1.PostedFile.FileName
        Else
            FileUploadReport.Text = "Please select a file before clicking" & " the 'Upload' button"
        End If

When using FileUpload1.PostedFile.FileName the filename is actually the entire path to the file so when checking if that file exists it won't work. Example: You browse for a file located at C:\Upload\Test.txt and you upload it the code was checking C:\Test\C:\Upload\Test.txt instead of C:\Test\Test.txt. So you should use System.IO.Path.GetFileName() and that will strip off the Directory path and give you just Test.txt

I hope that all makes sense...

bex · January 9th, 2009, 12:59 PM

that did it thanks