Erratta for AccountControllerTests

obiwaynekenobi · #1 (**permalink**) November 30th, 2009, 06:36 PM

It looks like the book was written using a preview release of ASP.NET MVC, as I found the following issue:

Code:

var typedResults = results as RedirectToRouteResult;
Assert.AreEqual("Index",
                typedResults.Values["action"],"Wrong action");
Assert.AreEqual("Home",
                typedResults.Values["controller"],
                "Wrong controller");

In the RC and 1.0 release of ASP.NET MVC the Views dictionary is changed to RouteViews so the code requires adding the assembly System.Web.Routing, and should be this instead:

Code:

Assert.AreEqual("Index", typedResults.RouteValues["action"], "Wrong action");
Assert.AreEqual("Home", typedResults.RouteValues["controller"], "Wrong controller");

Hope this helps anyone else who might run into this issue.

johnhilts · #2 (**permalink**) January 30th, 2010, 03:44 PM

I have noticed that NInject didn't work from Unit Tests until well into Chapter 8, when the IoC bindings were created in the Test Fixture Setup.

Before that, the book directs us to use NInject, but the tests would fail because the objects that were supposed to be injected were null references. To make the tests pass, you have to pass the mock object via the constructor or setter property, which you shouldn't have to do because the whole point of an IoC container is to do that for you. So I thought maybe there was some problem with NInject . . .

It's pretty clear that the neither the author nor the editor have actually worked through the book, or they would have seen this right away. The material covered is great, so we'll just need to fill in the gaps with the errata and hope for a better 2nd edition . . .

johnhilts · #3 (**permalink**) February 1st, 2010, 01:40 AM

On p 136 Undefined Code "Assert.Item" suddenly appears.

It can retrieved from the code download.

johnhilts · #4 (**permalink**) February 1st, 2010, 02:26 AM

The sort links on p.135 seem to use an old version of the Html.ActionLink API.

Tried to fix it, but don't know what the correct syntax would be.

Got it to compile, but clicking link results in NInject error.

Here's the link I tried:

Code:

<th>
<%=Html.ActionLink("Name",  ViewData.GetSortDirection("name"), ((PagedList<Contact>)ViewData.Model).PageNumber.ToString())
%>
</th>

Ciaro · #5 (**permalink**) February 28th, 2010, 11:21 AM

On page 36:

Before we can start cranking out tests, we need to create a test class. Let’s add a new test class for the
AccountController and name it AccountControllerTest. In order for it to be a test class, you deco-
rate it with MbUnit’s [TestFixture] attribute. Here is the class:
[TestFixture]
class AccountControllerTest
{
}

Then, there is a convention box, which clearly states test classes should be named plural (Tests).

Makes you kinda wonder if these books are reviewed before they are published...

P.S. Topic starter might as well re-name this topic to 'Errata'

Ciaro · #6 (**permalink**) February 28th, 2010, 11:22 AM

Quote:

Originally Posted by obiwaynekenobi

It looks like the book was written using a preview release of ASP.NET MVC, as I found the following issue:

Code:

var typedResults = results as RedirectToRouteResult;
Assert.AreEqual("Index",
                typedResults.Values["action"],"Wrong action");
Assert.AreEqual("Home",
                typedResults.Values["controller"],
                "Wrong controller");

In the RC and 1.0 release of ASP.NET MVC the Views dictionary is changed to RouteViews so the code requires adding the assembly System.Web.Routing, and should be this instead:

Code:

Assert.AreEqual("Index", typedResults.RouteValues["action"], "Wrong action");
Assert.AreEqual("Home", typedResults.RouteValues["controller"], "Wrong controller");

Hope this helps anyone else who might run into this issue.

Great catch, mate!

Need to download code?

Navigation