chapter 7, THUMBNAILS

r4n34 · October 18th, 2006, 01:18 PM

i have everything working great, except the fact my server doesnt have php 5 so i cant use the imagefilter() ANYWAY my problem..

i am creating the images perfectly, but my thumbnails are not being created.

permissions are 777 on both images and thumbs

so i am coming out with a page that doesnt show the thumbnails but everything else (links) working fine.

$ImageDir ="images/";

$ImageThumb = $ImageDir . "thumbs/";

$ImageName = $ImageDir . $image_tempname;

  $lastpicid = mysql_insert_id();

  $newfilename = $ImageDir . $lastpicid . ".jpg";

  if ($type == 2) {
    rename($ImageName, $newfilename);
  } else {
    if ($type == 1) {
      $image_old = imagecreatefromgif($ImageName);
    } elseif ($type == 3) {
      $image_old = imagecreatefrompng($ImageName);

    $image_jpg = imagecreatetruecolor($width, $height);
    imagecopyresampled($image_jpg, $image_old, 0, 0, 0, 0,
                     $width, $height, $width, $height);
    imagejpeg($image_jpg, $newfilename);
    imagedestroy($image_old);
    imagedestroy($image_jpg);
  }

$newthumbname = $ImageThumb. $lastpicid . ".jpg";

  $thumb_width = $width * 0.10;
  $thumb_height = $height * 0.10;

  $largeimage = imagecreatefromjpeg($newfilename);
  $thumb = imagecreatetruecolor($thumb_width, $thumb_height);
  imagecopyresampled($thumb, $largeimage, 0, 0, 0, 0,
                    $thumb_width, $thumb_height, $width, $height);
  imagejpeg($thumb, $newthumbname);
  imagedestroy($largeimage);
  imagedestroy($thumb);

what i need is to know why the thumbnails are not working.
thanks for any help you can give.

also if using the code from the book i have to many { 's

richard

redsatori · November 5th, 2006, 02:49 AM

Quote:

quote:

Code:

  if ($type == 2) {
    rename($ImageName, $newfilename);
    }
   else {
    if ($type == 1) {
      $image_old = imagecreatefromgif($ImageName);
      }
     elseif ($type == 3) {
       $image_old = imagecreatefrompng($ImageName);
 
       $image_jpg = imagecreatetruecolor($width, $height);
       imagecopyresampled($image_jpg, $image_old, 0, 0, 0, 0,
                       $width, $height, $width, $height);
       imagejpeg($image_jpg, $newfilename);
       imagedestroy($image_old);
       imagedestroy($image_jpg);
       }

Well, if this is the exact code you are using, you are short quite a '}' As it stands, your original if statement's else clause is not closed, causing everything that follows to be included in the else clause. You actually have two solution possible here, this is what I think should be done:

Code:

  if ($type == 2) {
    rename($ImageName, $newfilename);
  } elseif ($type == 1) {
      $image_old = imagecreatefromgif($ImageName);
  } elseif ($type == 3) {
      $image_old = imagecreatefrompng($ImageName);
  }
    $image_jpg = imagecreatetruecolor($width, $height);
    imagecopyresampled($image_jpg, $image_old, 0, 0, 0, 0,
                     $width, $height, $width, $height);
    imagejpeg($image_jpg, $newfilename);
    imagedestroy($image_old);
    imagedestroy($image_jpg);

YUou could also try switching that statement to a 'switch' statement for maintainability.

ratxamala · November 24th, 2006, 09:26 PM

Ok... i got the same problem when im going to create the thumbnails

the code is:

$largeimage = imagecreatefromjpeg($newfilename);

and the error is:

Fatal error: Call to undefined function: imagecreatefromjpeg()

i dont know why if in my php.ini the library php_gd2.dll is not commented please help