I need to replace a collection when it is passed from another class.
In the sample code below, test 1 gives the correct result (ie "Col2") and test2 gives the wrong result ("Col1"). Unfortunately I need to use the indirect method used in test2 (as "oldCol", "setCol" and the tests are actually in a different class from the rest of the code).

Please can you help to sort out test2 so it can still be called without any parameter but returns col2.

Many thanks

Phil


Module Module1

    Sub Main()
        Dim col As New Collection
        col.Add("Col1")
        setCol(col)

        test1(col)
        MsgBox("test1=" & col(1))

        col.Clear()
        col.Add("Col1")
        test2()
        MsgBox("test2=" & col(1))
    End Sub

    Sub sub1(ByRef oldcol As Collection)
        Dim newCol As New Collection
        newCol.Add("Col2")
        oldcol = newCol
    End Sub
'-----------------------------------New class
    Dim oldCol As Collection

    Sub setCol(ByRef col As Collection)
        oldCol = col
    End Sub

    Sub test1(ByRef col As Collection)
        sub1(col)
    End Sub

    Sub test2()
        sub1(oldCol)
    End Sub
End Module

I'm not sure you can do it exactly like this. When you call test2, it calls sub1 which updates oldCol. But oldCol is just a reference to the original collection col. The variable col is also a reference, initially to the same collection, but making oldCol point to a new collection doesn't change what col points at.

You need some sort of common variable that both the main program and the class can both see if you want this to work. For example, you could have the main program not keep its own reference to the collection and have the class expose oldCol publicly. Or you could use a global variable (as much as I prefer to avoid them).

Rod

Rod Stephens, Visual Basic MVP
RodStephens@vb-helper.com

*** New Book ***
"Visual Basic 2008 Programmer's Reference"

Sign up for the free VB Helper Newsletters at http://www.vb-helper.com/newsletter.html