script from book not working

whyulil · November 18th, 2003, 11:57 AM

i cant see where im going wrong. The code is supposed to produce the times table based on the values at the end of the script:
writeTimesTable(4,4,9)

However it only writes
4 * 10 = 40

Can anybody spot my mistake? ive gone over it 5 times and i cant see the mistake.

<html>
<body>
<script language="JavaScript">
function writeTimesTable(timesTable, timesByStart, timesByEnd)
{
    for (; timesByStart <= timesByEnd; timesByStart++);
    {
            document.write(timesTable + " * " + timesByStart + " = " + timesByStart * timesTable + "<br>");
    }
}

writeTimesTable(4,4,9);
</script>
</body>
</html>

JayinOC · November 18th, 2003, 01:46 PM

I think I found it.

for (; timesByStart <= timesByEnd; timesByStart++);

is the line that is screwing you up. I had no idea it would cause JS to mess up but the " ; " you have after the function parameters is what is doing it. Take out the semicolon from that line and you should be good to go.

I am totally new to Java Script and these chapter 3 examples nearly made me want to jump off the roof. This stuff is pretty hard for me.

pgtips · November 18th, 2003, 01:50 PM

You had me going for a while here :).

Remove the ; from the end of this line
for (; timesByStart <= timesByEnd; timesByStart++);
otherwise you're closing the loop and the rest of the code is only executed once after the loop finishes.

hth
Phil

pgtips · November 18th, 2003, 01:53 PM

You see, I took so long to spot it someone else beat me to it :D

JayinOC · November 18th, 2003, 01:56 PM

Quote:

quote:Originally posted by pgtips
You see, I took so long to spot it someone else beat me to it :D

And a rookie at that !!! :D