Access VBA help needed...!!

jonwitts · May 3rd, 2005, 03:04 AM

Hi I currently making a accident reporting database for my employers. I have built all of the tables and forms and have set up the relationship model. However I am currently have some problem with the VBA code of my buttons. On the bottom of each form I have a button that will save the form, close it and then open the next form in the input process. However on some forms depending on one of the fields selected on that form, I need a different form to open than all other options. I thought I would be able to this with a "If Else" command.

Here is the code I am using at the moment, which does not appear to help...

Private Sub SaveRecord_Click()

If Me.IncidentKind = "FallofHeight" Then
DoCmd.Save
DoCmd.Close
DoCmd.OpenForm "FallofHeight"

Else

DoCmd.Save
DoCmd.Close
DoCmd.OpenForm "Recording"

End If

End Sub

BrianWren · May 3rd, 2005, 01:23 PM

Jon: Use indenting!

You take some identical steps, irrespective of the condition, so your intent would be easier to follow (both for you and for others) if the conditional step was all that was inside the âIfâ block:

Code:

Private Sub SaveRecord_Click()

    DoCmd.Save
    DoCmd.Close

    If Me.IncidentKind = "FallofHeight" Then
        DoCmd.OpenForm "FallofHeight"
    Else
        DoCmd.OpenForm "Recording"
    End If

End Sub

You could even make it clearer with

Code:

Private Sub SaveRecord_Click()

    Dim NextForm As String

    If Me.IncidentKind = "FallofHeight" Then
        NextForm = "FallofHeight"
    Else
        NextForm = "Recording"
    End If

    DoCmd.Save
    DoCmd.Close
    DoCmd.OpenForm NextForm 

End Sub

What kind of a thing is Me.IncidentKind?
You say âHere is the code I am using at the moment, which does not appear to help...â: What does it do? What is the result that you get that is not helpful?

jonwitts · May 4th, 2005, 02:26 AM

Me.IncidentKind is a drop down combination box with "FallofHeight" being one of the posible selections. The problem I am getting is that even if "FallofHeight" is selected in Me.IncidentKind drop down box, the form "Recording" is still opening when the code is executed.

Do I need to include an error catcher in this too?

leehambly · May 4th, 2005, 08:50 AM

what value is stored in your combo box?

Is it the id of the lookup or the actual text "FallofHeight"?

If this isnt working, I would guess it is the id of the lookup rather than the actual text, or your code value "FallofHeight" doesnt match the value in the combo box.

jonwitts · May 4th, 2005, 09:41 AM

Thanks for this.. It was indeed that I was trying to use the id of the lookup as the value.. Have changed it now and it all works beautifully.

Cheers.