Hi

I have a query QConfirm which populates a Form
The Query is filtered Date to Date and QuoteControl must = True

The Controls in the query are

Date: Quote: ConfirmedOrder
Quote and ConfirmedOrder are Boolean (True of False)

When Order initially raised Quote is True ConfirmedOrder is False
I wish to automatically change

Quote to False
Confirmed True

When I run the code below the error comes up as

"Loop Without Do"

I think the SQL Logic is okay but I am either using the wrong technique to cycle thru the records

Or the SQL is in the wrong place in the procedure
Help Would Be appreciated



Private Sub CmdConfirmOrders_Click()
On Error GoTo Err_CmdConfirmOrders_Click

Dim rstTemp As DAO.Recordset
Dim RecCount As Integer

  Set rstTemp = CurrentDb.OpenRecordset( _
  "SELECT Quote,ConfirmedOrder FROM QConfirm")

  'Move to last record to get the record count
  rstTemp.MoveLast
  RecCount = rstTemp.RecordCount

 'Start the loop
 Loop Until RecCount = 0

    RecCount = rstTemp.RecordCount - 1

    rstTemp.MoveFirst
    If Quote = True And ConfirmedOrder = False Then
    Quote = False And ConfirmedOrder = True
 Loop

 'requery the form
 Me.Requery


 'disable the Cmd Button to avoid an error when no records exist in the Query
Me.CmdConfirmOrders.Enabled = False

MsgBox "All Records have been successfully Updated", vbOKOnly
rstTemp.Close




Exit_CmdConfirmOrders_Click:
    Exit Sub

Err_CmdConfirmOrders_Click:
    MsgBox Err.Description
    Resume Exit_CmdConfirmOrders_Click

End Sub

Sorry for the delay in the reply. Here is the error:

This:
'Start the loop
 Loop Until RecCount = 0

    RecCount = rstTemp.RecordCount - 1

    rstTemp.MoveFirst
    If Quote = True And ConfirmedOrder = False Then
    Quote = False And ConfirmedOrder = True
 Loop

Should be this:
'Start the loop
Do Until RecCount = 0
    RecCount = rstTemp.RecordCount - 1
    rstTemp.MoveFirst
    If Quote = True And ConfirmedOrder = False Then
       Quote = False And ConfirmedOrder = True
    End If
Loop

This doesn't look right, though. If you start this loop, you are only acting on the first record in the recordset, time after time, until you decrement the RecCount variable.

Perhaps you mean this:
'Start the loop
rstTemp.MoveFirst 'moved
Do Until RecCount = 0
    RecCount = rstTemp.RecordCount - 1
    If Quote = True And ConfirmedOrder = False Then
       Quote = False And ConfirmedOrder = True
    End If
    rstTemp.MoveNext 'added
Loop

I am not sure if you can act on a DAO recordset as you do in the If Then conditional, but you wouldn't accomplish anything in ADO this way.

Did any of that help?

mmcdonal

mmcdonal
Hi

This post is linked to the "Using SQL within VBA which was my second attempt at SQL within VBA to solve the problem of changing Quote to No and Making Firm Order Yes

I have one or two other things to try and when the problem is solved I will have increased my understanding of how to construct SQL correctly for use in VBA editor

I think that when the IF THEN statement is code which is attached to a Cmd button on a FORM it does work. I have yet to try it using a DO LOOP circumstance so I hope it still works


Thank you for both yours and other contributors assistance

Man Friday