Why is my delete button still deleting a record even when I hit cancel. Help please! Thanks. Here is my code:

JAVASCRIPT CODE

function before_delete()
{
     // PROMPTS REQUIRE TWO ARGUMENTS
    var task = document.frmPSATasks.tasknum.value;
    var agreement = document.frmPSATasks.agreementnum.value;
    var message = "Are you sure you want to delete task no " + task + " ?";
    var value_name = "";
    // PROMPTS RETURN TWO POSSIBLE VALUES
    // IF THE USER TYPES ESCAPE OR CLICKS CANCEL
    // THE RETURN VALUE IS NULL
    // IF THE USER TYPES RETURN OR CLICKS OK
    // THE INPUT LINE STRING IS RETURNED
    var return_value = confirm(message,value_name);

    if (return_value == false)
    {
        alert('Delete Cancelled!');
    }
    else
    {
        // Set the hidden variable to the task number
        document.frmPSATasks.tasknumhidden.value = task;
        document.frmPSATasks.agreementnumhidden.value = agreement;
        document.frmPSATasks.submit();
    }
}

AND FUNCTION CODE:

Function deleteTaskOrder()
    ' Local Recordset
    dim rsLocalDel
    ' Delete Contract
    Set rsLocalDel = server.CreateObject("adodb.recordset")
    SQL = "Select * from tblTasks where agreement_no = '" & strAgreementNum & "' and task_order = '" & strTaskNum & "'"
    Response.Write "We are deleting " & sql
    ' Run Query
    rsLocalDel.open SQL, cn, 0, 3
    ' Check to see if task exists
    if rsLocalDel.recordcount = 1 Then
    'if not rsLocalDel.eof Then
        ' deletes record
        With rsLocalDel
            .delete
            '.movenext
            .close
        End With
    Else
        ' Deleting more than one record, display error message
        Response.Write " Error: Attempting to delete " & rsLocalDel.recordcount &" records is not allowed. Please contact system administrator."
        'Response.Write "Error: Estimate Number " & strTaskNum & " no longer exists!"
    End If
    set rsLocalDel = nothing
End Function

select case btnAction
    case "Add"
        ' Add the task order
        if strAgreementNum <> "" and strTaskNum <> "" then ' Make sure user entered a value
            addTaskOrder()
           ' After the add, perform a search to reload agreement no :)
            searchAgreementNo
        end if
    case "Update"
        ' Update the task order
        if strAgreementNum <> "" then
            updateTaskOrder()
            ' After the update, perform a search to reload agreement no :)
            searchAgreementNo
        end if
    case "Delete"
        'Delete the task order
        if strTaskNum <> "" then
            deleteTaskOrder()
            ' After the delete, perform a search to reload agreement no :)
            'searchAgreementNo
        end if
    case ""
        ' Process the search
        if strAgreementNum <> "" then
            searchAgreementNo
        end if
   end select



slypunk

__________________
slypunk

Where are you calling before_delete and where are you calling deleteTaskOrd?

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

it is in the same file see the delete button is calling both the function deleteTaskOrder and the javascript function before_delete. I hope I explained this well

slypunk

Is one running on the server and one on the client? Can you post the code for the button that triggers the action?

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

here is the button:
<input type="submit" name="btnAction" value="Delete" onclick="return before_delete();">

Function deleteTaskOrder()
    ' Local Recordset
    dim rsLocalDel
    ' Delete Contract
    Set rsLocalDel = server.CreateObject("adodb.recordset")
    SQL = "Select * from tblTasks where agreement_no = '" & strAgreementNum & "' and task_order = '" & strTaskNum & "'"
    Response.Write "We are deleting " & sql
    ' Run Query
    rsLocalDel.open SQL, cn, 0, 3
    ' Check to see if task exists
    if rsLocalDel.recordcount = 1 Then
    'if not rsLocalDel.eof Then
        ' deletes record
        With rsLocalDel
            .delete
            '.movenext
            .close
        End With
    Else
        ' Deleting more than one record, display error message
        Response.Write " Error: Attempting to delete " & rsLocalDel.recordcount &" records is not allowed. Please contact system administrator."
        'Response.Write "Error: Estimate Number " & strTaskNum & " no longer exists!"
    End If
    set rsLocalDel = nothing
End Function

' --- PROCESSING LOGIC STARTS BELOW

........


' Process the Add/Update/Delete/Search functions
btnAction = request("btnAction")
select case btnAction
    case "Add"
        ' Add the task order
        if strAgreementNum <> "" and strTaskNum <> "" then ' Make sure user entered a value
            addTaskOrder()
           ' After the add, perform a search to reload agreement no :)
            searchAgreementNo
        end if
    case "Update"
        ' Update the task order
        if strAgreementNum <> "" then
            updateTaskOrder()
            ' After the update, perform a search to reload agreement no :)
            searchAgreementNo
        end if
    case "Delete"
        'Delete the task order
        if strTaskNum <> "" then
            deleteTaskOrder()
            ' After the delete, perform a search to reload agreement no :)
            'searchAgreementNo
        end if
    case ""
        ' Process the search
        if strAgreementNum <> "" then
            searchAgreementNo
        end if
   end select

slypunk

Ah, I see. You should return false from the confirmation method:

function before_delete()
{
 if (return_value == false)
    {
        alert('Delete Cancelled!');
        return false;
    }

HtH,

Without the false, the button still submits....

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

AWESOME! THAT WAS IT! THANK YOU

slypunk

Hi,
 Why dont use "Confirm"... as below

dunction doDelete()
{
   if(Confirm("Do u want to delete the reocord?"))
   {
       return true;
   }
   else
   {
       return false;
   }

}

Or even:

function doDelete()
{
   return confirm('Are you sure you want to delete this record?');
}


Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.