Index out of range form question

harpua · February 23rd, 2004, 06:45 PM

Can somebody please explain to me why this is happening. I have a form like a shopping cart with the product name, quantity text field. The deli has 3 quantity fields while the bakery products only have one. This will update in a database once I figure out my problem.

This is whats happening, if I have 3 deli products everything writes out fine. Next I add a bakery product and then another deli product and I receive the following error.

Request object error 'ASP 0105 : 80004005'
Index out of range
/update_qty.asp, line 165
An array index is out of range.

For iProductCount=1 to Request.Form("fBasket").Count
If Request.Form("dept")(iProductCount) = "deli" Then
Response.Write Request.Form("dept")(iProductCount) & "Dept "
Response.Write Request.Form("fQuantity_01")(iProductCount) & "QTY-1 "
Response.Write Request.Form("fQuantity_02")(iProductCount) & "QTY-2 "
Response.Write Request.Form("fQuantity_03")(iProductCount) & "QTY-3 "
Response.Write Request.Form("fBasket")(iProductCount) & "--ID "
Else
Response.Write Request.Form("dept")(iProductCount) & "Dept "
Response.Write Request.Form("fQuantity_01")(iProductCount) & "QTY-1 "
Response.Write Request.Form("fBasket")(iProductCount) & "--ID "
End If
Next

Thanks In Advance
Mike Moore

planoie · February 24th, 2004, 12:14 AM

I suspect the problem you are having has to do with the conditional creation of form elements. For the first 3 deli products you create the 5 elements (dept, qty1, qty2, qty3, basket). The bakery product only creates 3 of those (all but qty2 and qty3). So in the end the array length for qty1 is different from qty2 and qty3.

Consider just the quantity fields. Here's a table of the array indexes for each of the resulting values of those fields for each product:

Code:

        |- Indexes --|
Item    qty1 qty2 qty3
Deli1   0    0    0
Deli2   1    1    1
Deli3   2    2    2
Bakery1 3    -    -
Deli4   4    3    3

So when you loop thru the items and you get to deli item 4, you try to get qty2 field index 4 which doesn't exist, thus the out of range error.

The solution to this problem is to always draw out all possible fields for a product regardless if you actually need to use them. In the case of a bakery product you don't need to use the qty2 and qty3 fields, but it does no harm to have them there because you can just ignore them. But more importantly, they are required to keep your arrays in sync.

Peter
------------------------------------------------------
Work smarter, not harder.