Can't update!!

comicghozt · June 21st, 2006, 08:38 AM

Hello!

I'm trying to set an edit button on my page but I can't get it working.
Could someone tell me what am I doing wrong?

(sorry for the size)

<%@ Import Namespace="System.Data" %>
<%@ Import Namespace="System.Data.OleDB" %>
  <%@ Page Language="VB" Debug="true" %>

<html>

<script language="VB" runat="server">

    Sub Page_Load(Sender As Object, E As EventArgs)
        If Not Request.QueryString("id") Is Nothing

                Dim DS As DataSet
                Dim MyConnection As OleDBConnection
                Dim MyCommand As OleDBDataAdapter

                Dim Query As String
                Query = "select * from Tabela where id = @id"

                MyConnection = New OleDBConnection("Provider=Microsoft.Jet.OLEDB.4.0; " & "Data Source=C:\Inetpub\wwwroot\DOT\pessoal\ECO.PATROL - PESSOAL.mdb")
                MyCommand = New OleDBDataAdapter(Query, MyConnection)

                Dim param As OleDBParameter = New OleDBParameter("@id", DbType.String)
                param.Value = Server.HtmlEncode(Request.QueryString("id"))
                myCommand.SelectCommand.Parameters.Add(param)

                DS = New DataSet()
                MyCommand.Fill(DS, "Tabela")

                MyDataList.DataSource = DS.Tables("Tabela").DefaultView
                MyDataList.DataBind()
            End If

    End Sub

    Sub MyDataList_Edit(Sender As Object, E As DataListCommandEventArgs)

        MyDataList.EditItemIndex = CInt(e.Item.ItemIndex)

                MyDataList.DataBind()
    End Sub

    Sub MyDataList_Update(Sender As Object, E As DataListCommandEventArgs)

        Dim MyConnection as New OleDBConnection("Provider=Microsoft.Jet.OLEDB.4.0; " & "Data Source=C:\Inetpub\wwwroot\DOT\pessoal\ECO.PATROL - PESSOAL.mdb")
    Dim MyCommand As New OleDBDataAdapter("update Tabela set nacionalidade=@nacionalidade where id=@id", MyConnection)

        Dim EditText As HtmlInputText
        EditText = E.Item.FindControl("edit")

        Message.InnerHtml = "ActualizaÃ§Ã£o efectuada: " & EditText.Value
        MyDataList.EditItemIndex = -1

                MyDataList.DataBind()
    End Sub

    Sub MyDataList_Cancel(Sender As Object, E As DataListCommandEventArgs)

        MyDataList.EditItemIndex = -1
                MyDataList.DataBind()
    End Sub

</script>

<body topmargin="0" leftmargin="0" marginwidth="0" marginheight="0">

  <form runat="server">

    <table>
      <tr>
        <td valign="top">

          <ASP:DataList id="MyDataList" OnEditCommand="MyDataList_Edit" OnUpdateCommand="MyDataList_Update" OnCancelCommand="MyDataList_Cancel" runat="server">

              <ItemTemplate>

                <table cellpadding=10 style="font: 10pt verdana">
                  <tr>
                    <td width=1 bgcolor="BD8672"/>
                    <td valign="top">
                      <IMG alt="foto" SRC='fotos/<%# DataBinder.Eval(Container.DataItem, "fotografia") %>' width="100" Border="1"><br>
                    </td>
                    <td valign="top">
                      <b>Nome: </b><%# DataBinder.Eval(Container.DataItem, "nome") %><br>
                      <b>Morada: </b><%# DataBinder.Eval(Container.DataItem, "morada") %><br>
                      <b>Nacionalidade: </b><%# DataBinder.Eval(Container.DataItem, "nacionalidade") %><br>
             <b>NÃºmero: </b><%# DataBinder.Eval(Container.DataItem, "numero") %><br>
            <asp:linkbutton CommandName="Edit" runat="server">
                <img alt="edit book" border="0" src="images/edit_book.gif" >
              </asp:linkbutton>
                    </td>
                  </tr>
                </table>

              </ItemTemplate>

      <EditItemTemplate>

        <table cellpadding=10 style="font: 10pt verdana">
          <tr>
            <td width=1 bgcolor="BD8672"/>
            <td valign="top">
              <b>Title: </b><%# DataBinder.Eval(Container.DataItem, "nome") %><br>
              <b>Category: </b><%# DataBinder.Eval(Container.DataItem, "morada") %><br>
              <b>Publisher ID: </b><%# DataBinder.Eval(Container.DataItem, "numero") %><br>
              <b>Price: </b><input id="edit" type="text" value='<%# DataBinder.Eval(Container.DataItem, "nacionalidade") %>' runat="server"/>
              <p>
              <asp:linkbutton CommandName="Update" runat="server"><img alt="update" border="0" src="images/update_book.gif" ></asp:linkbutton>
              <asp:linkbutton CommandName="Cancel" runat="server"><img alt="cancel" border="0" src="images/cancel_book.gif" ></asp:linkbutton>
            </td>
          </tr>
        </table>

      </EditItemTemplate>

          </ASP:DataList>

        </td></tr>

    </table>

  </form>
  <div style="font: 10pt verdana;padding:0,15,15,15" id="Message" runat="server"/>

</body>
</html>

rstelma · June 21st, 2006, 12:23 PM

You didn't mention what the problem or symtoms are???

I just use this code:

<asp:Button ID="Button1" Text="Update" OnClick="UpdateDate" Runat="server" />

The onclick value points to the actual sub that does the updating.

comicghozt · June 22nd, 2006, 03:57 AM

Hallo!

I want to let the user edit a record. Right now the code doesn't update the DB, keeping the same old values and I got no errors.

If u would mind the find the errors and explain me what the problem is like if I was really dum... LOL.

Thanks a lot...

rstelma · June 22nd, 2006, 10:52 AM

I don't see your link button doing anything. There's no sub that handles the action of the button. In my example there is an onclick event associated with the button. However, you can also accomplish this in the code behind.

Protected WithEvents btnUpdate As Button

Sub getComponentGroups(ByVal sender As Object, ByVal e As EventArgs) Handles btnUpdate.Click
'Put your update code in here.
End Sub

Also, I don't see an ID="btnUpdate" in your code either, to identify your button. I'm not an expert. Hope this helps.

dparsons · June 22nd, 2006, 12:06 PM

The linkbuttons do not have a click event assoiated with them, his buttons SHOULD trigger the sub routines defined in his datagrid On[Command] properties.

"The one language all programmers understand is profanity."

comicghozt · June 26th, 2006, 07:15 AM

Hey!

But shouldn't the CommandName="Update" and
Sub MyDataList_Update... be enough?

I'm learning from here:
http://www.asp.net/QuickStart/util/s.../DataList9.src

Thanx in advance...

dparsons · June 26th, 2006, 07:59 AM

Do you know for sure that MyDataList_Update is being called? e.g., Have you stepped through the code to make sure that sub is being called, or put a Response.write to write some text out to the screen?

This will at least narrow the problem down to: is it a problem with the datagrid or is it a problem with the routine.

Hth.

"The one language all programmers understand is profanity."

comicghozt · June 26th, 2006, 10:38 AM

I'm using the following code:
  <div style="font: 10pt verdana;padding:0,15,15,15" id="Message" runat="server"/>
and I get the new value printes but the record keeps the old value.

I've made the following changes in the Update procedure:
(I think I mixing up everything...)
    Sub MyDataList_Update(Sender As Object, E As DataListCommandEventArgs)

    Dim Conn as OleDbConnection
        Dim MyConnection as String = "Provider=Microsoft.Jet.OLEDB.4.0;" & "Data Source=C:\Inetpub\wwwroot\DOT\pessoal\bd1.mdb"
        Dim SQL as String = "update Tabela set numero=@numero"
    Dim Cmd as OleDbCommand

        Dim EditText As HtmlInputText
        EditText = E.Item.FindControl("edit_price")
    conn = New OleDbConnection(MyConnection)
    Cmd = New OleDbCommand(SQL, conn)
    Cmd.Parameters.Add(New OleDbParameter("@numero", EditText.value))

    Conn.Open()
    cmd.ExecuteNonQuery()
        MyDataList.EditItemIndex = -1
        Message.InnerHtml = "Price Updated: " & EditText.Value
    Conn.close
        PopulateList()
    End Sub

...and now I get the error (translated):

"The operation must use an updatable query"

Suggestions?