Hi,

I'm having problems with my checkboxlist. Currently, my checkboxlist is read from a database of fieldnames once the page is loaded. If the user clicks on the Save button, it checks to see what was selected and the variable 'field' is set to 'y' or 'n' if it's not selected. I do this for the whole checkboxlist. The contents in 'field' are then set to the session("test") which is loaded on the next page. However, it says 'n' for all of them. Is there any reason why? Can someone please tell me what is going on? Thanks.

Here is my code:

Private Sub Page_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
         Session("recordcount") = ""
        SqlDataAdapter1.Fill(DsVenSel1)
        Session("recordcount") = DsVenSel1.Tables("syscolumns").Rows.Count.ToString
        cmdSave.Text = Session("recordcount")
        ChkLstVen.DataSource = DsVenSel1
        ChkLstVen.DataTextField = "Name"
        ChkLstVen.DataBind()
End Sub

    Private Sub cmdSave_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles cmdSave.Click
        Dim i
        Dim field As String
        field = ""
        For i = 0 To ((Session("recordcount")) - 1)
            If ChkLstVen.Items(i).Selected Then
                If i = 0 Then
                    field = "Y"
                ElseIf i > 0 Then
                    field = field & "Y"
                End If
            ElseIf Not (ChkLstVen.Items(i).Selected) Then
                If i = 0 Then
                    field = "N"
                ElseIf i > 0 Then
                    field = field & "N"
                End If
            End If
        Next
  Session("test") = field
        Response.Redirect("DataSelFin.aspx")
End Sub

why don't you try the for loop like this


for each chk as checkbox in chklstven.items
   if chk.checked then
     'Code
   elseif not (chk.checked) then
     'Code
   end if
next

I get the following error when I change my code to what was suggested:

Server Error in '/CPS' Application.
--------------------------------------------------------------------------------

Specified cast is not valid.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.InvalidCastException: Specified cast is not valid.

Source Error:


Line 86: field = ""
Line 87: 'For i = 0 To ((Session("recordcount")) - 1)
Line 88: For Each chk As CheckBox In ChkLstVen.Items
Line 89: If chk.Checked Then
Line 90:


Source File: c:\inetpub\wwwroot\CPS\DataSelVen.aspx.vb Line: 88

Stack Trace:


[InvalidCastException: Specified cast is not valid.]
   CPS.DataSelVen.cmdSave_Click(Object sender, EventArgs e) in c:\inetpub\wwwroot\CPS\DataSelVen.aspx.vb:88
   System.Web.UI.WebControls.Button.OnClick(EventArgs e) +108
   System.Web.UI.WebControls.Button.System.Web.UI.IPo stBackEventHandler.RaisePostBackEvent(String eventArgument) +57
   System.Web.UI.Page.RaisePostBackEvent(IPostBackEve ntHandler sourceControl, String eventArgument) +18
   System.Web.UI.Page.RaisePostBackEvent(NameValueCol lection postData) +33
   System.Web.UI.Page.ProcessRequestMain() +1292


Did I do something wrong?

in the declaration what is chkLstVen declared as?

is should be declared something like this

Protected WithEvents chkLstVen As System.Web.UI.WebControls.CheckBoxList

It's declared as:

Protected WithEvents ChkLstVen As System.Web.UI.WebControls.CheckBoxList

try this see waht it does

  For Each chk As CheckBox In ChkLstVen.Items
            Response.Write(chk.Checked)
        Next

It gives me the same error.

mh,

The problem is that you are binding the list of checkboxes every time the page loads so all the checkbox values are getting reset. You need to load the checkbox list only on the first page load (If Not IsPostback) or on some other one-time event.

-Peter

Thank you, Peter and Mayur52o for your help. It now works.

But, I've come across a different problem now. I'm calling a stored procedure to save what was checked from the checkboxlist into a database. I require some parameters such as Login Id. However, it keeps on saying that my login id is null when it isn't. Each time I hardcode/set something equal to login id, it saves. However, when I try to use the same id again, it doesn't work. Am I doing something wrong? Also, inside my stored procedure, it allows records to be overwritten if it contains the same id, otherwise it creates a new record if the id is new. Here is what I have:

 Private Sub Page_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        If Not Page.IsPostBack Then
            Session("recordcount") = ""
            SqlDataAdapter1.Fill(DsVenSel1)
            Session("recordcount") = DsVenSel1.Tables("syscolumns").Rows.Count.ToString
            cmdSave.Text = Session("recordcount")
            ChkLstVen.DataSource = DsVenSel1
            ChkLstVen.DataTextField = "Name"
            ChkLstVen.DataBind()
        End If
    End Sub

    Private Sub cmdSave_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles cmdSave.Click
        Dim i
        Dim field As String
        field = ""
        For i = 0 To ((Session("recordcount")) - 1)
            If ChkLstVen.Items(i).Selected Then
                If i = 0 Then
                    field = "1"
                ElseIf i > 0 Then
                    field = field & "1"
                End If
            ElseIf Not (ChkLstVen.Items(i).Selected) Then
                If i = 0 Then
                    field = "0"
                ElseIf i > 0 Then
                    field = field & "0"
                End If
            End If
        Next
        Session("test") = field

        Dim myCmd As System.Data.SqlClient.SqlCommand = New System.Data.SqlClient.SqlCommand("cps3_DataSel", SqlConnection1)
        myCmd.CommandType = CommandType.StoredProcedure

        Dim param1 As New System.Data.SqlClient.SqlParameter("@FieldType", SqlDbType.VarChar)
        param1.Direction = ParameterDirection.Input
        param1.Value = "Ven"
        myCmd.Parameters.Add(param1)
        Dim param2 As New System.Data.SqlClient.SqlParameter("@LoginId", SqlDbType.VarChar)
        param2.Direction = ParameterDirection.Input
        param2.Value = "try"
        myCmd.Parameters.Add(param2)
        Dim param3 As New System.Data.SqlClient.SqlParameter("@SpecName", SqlDbType.VarChar)
        param3.Direction = ParameterDirection.Input
        param3.Value = lblSpecName.Text
        myCmd.Parameters.Add(param3)
        Dim param4 As New System.Data.SqlClient.SqlParameter("@GrpName", SqlDbType.VarChar)
        param4.Direction = ParameterDirection.Input
        param4.Value = ""
        myCmd.Parameters.Add(param4)
        Dim param5 As New System.Data.SqlClient.SqlParameter("@Field", SqlDbType.VarChar)
        param5.Direction = ParameterDirection.Input
        param5.Value = Session("Test")
        myCmd.Parameters.Add(param5)

        SqlConnection1.Open()
        myCmd.ExecuteNonQuery()
        SqlConnection1.Close()
        Response.Redirect("DataRun.aspx")
    End Sub
End Class

And this is the error I get:

Server Error in '/CPS' Application.
--------------------------------------------------------------------------------

Cannot insert the value NULL into column 'LoginId', table 'FNTIC_CPES.dbo.CPES_VenSel'; column does not allow nulls. INSERT fails. The statement has been terminated.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.Data.SqlClient.SqlException: Cannot insert the value NULL into column 'LoginId', table 'FNTIC_CPES.dbo.CPES_VenSel'; column does not allow nulls. INSERT fails. The statement has been terminated.

Source Error:


Line 130:
Line 131: SqlConnection1.Open()
Line 132: myCmd.ExecuteNonQuery()
Line 133: 'flag = myCmd.Parameters("@flag").Value
Line 134: SqlConnection1.Close()


I appreciate all the help that is provided. Thanks.