Validation Problem

RPG SEARCH · May 26th, 2005, 09:49 AM

Hi there,

I have a button that when clicked fires an Insert command. in the past I kept putting blank records into the database so what I thought is to put a validator in.

What happens now is i click the button, it tells me the textbox is required... i put something i click button it says updated... and then when i go to click a button that hides the current panel and opens a new one it won't let me.... says required. in the status bar it has a javascript message. I dont i am doing it right...

Button
--------

Code:

 Private Sub btnAddNews_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnAddNews.Click
        If IsValid Then

            'Convert the article so that it can be into the database.
            Dim ArticleText As String = MyCstr(txtNewsArticle.Text, True, True)
            Dim connectionString As String = "Provider=Microsoft.Jet.OLEDB.4.0;" & _
            "Data Source=C:\Inetpub\wwwroot\davejenkinscouk\davesdatabase.mdb"
            Dim dbConnection As System.Data.IDbConnection = New System.Data.OleDb.OleDbConnection(connectionString)
            dbConnection.Open()
            Dim strSQL As String = "INSERT INTO tbl_News(NewsTitle, NewsArticle, NewsImage, NewsLink, NewsComments) values('" & _
              txtNewsTitle.Text & "','" & _
              ArticleText & "','" & _
              txtNewsImage.Text & "','" & _
              txtNewsLinks.Text & "','" & _
              chkComments.Checked & "')"

            Dim myCommand As New OleDb.OleDbCommand(strSQL, dbConnection)

            myCommand.ExecuteNonQuery()
            dbConnection.Close()

            'Rebind the datagrid
            dgNewsArticles.DataSource() = getNewsArticles()
            dgNewsArticles.DataBind()

            'If it inserts correctly then the following is displayed.....
            showNewsMessage.Visible = "True"
            showNewsMessage.Text = "record added successfully."

            'Clear the field values.
            txtNewsTitle.Text = ""
            txtNewsArticle.Text = ""
            txtNewsImage.Text = ""
            txtNewsLinks.Text = ""
            chkComments.Checked = "False"
        End If

    End Sub

with a normal validator there checking the txtNewsTitle.Text box..

cheers

David Jenkins
-------------------------------------------------------------
Do you want to make extra money around your commitments?
Credit cards, bills, loans and a mortgage - all getting you down?
Is your pension going to be enough when you retire?
There is a solution visit http://www.1stmillion.co.uk
or call 01772 489521

jbenson001 · May 26th, 2005, 12:13 PM

On the button that you use to hide the panel, set CausesValidation to false.

Hal Levy · May 26th, 2005, 08:09 PM

That will do it... I just want to add that you should be using an object to insert, rather than directly from the aspx page.. this way you can validate at the object, and your business logic (of what's required) isn't tied to the UI... I would also put constraints on the database to prevent blank rows from being inserted.

Hal Levy
I am here to help you, not do it for you.
That is, unless you hire me. I am looking for work.

RPG SEARCH · May 27th, 2005, 09:41 AM

Cool - thanks that worked.

A follow on question is ... because I have about 5 hidden panels will all controls on the page then needing setting validtion as false.

Hal following in from what you say.... I should put the insert command into a function then instead? Everytime i try and stop blank inserts going in it goes wrong for me, what is the best way to approach this?

At the moment this is for my personal website so i dont mind it being a bit dirty(?) and direct - hehe. thanks for the tips though!

David Jenkins
-------------------------------------------------------------
Do you want to make extra money around your commitments?
Credit cards, bills, loans and a mortgage - all getting you down?
Is your pension going to be enough when you retire?
There is a solution visit http://www.1stmillion.co.uk
or call 01772 489521

Hal Levy · May 30th, 2005, 06:23 PM

David,

your aspx page shouldn't talk to the database directly. You should create a business layer (and a data layer) and then bind to the properties on the business side.

The business side, when you tell it to save to the DB, can run a validation against the properties to make sure they are populated before writing out to the DB.

You should also, as I said, set the fields to non-nullable in your backend database.

Hal Levy
I am here to help you, not do it for you.
That is, unless you hire me. I am looking for work.

RPG SEARCH · May 31st, 2005, 04:18 AM

Cool thanks, I will do that with the database right away. And thanks for the other information I will explore it a little as i dont think i understand this business section (is that just the code behind?) i wouldnt say i am new to this but i am not a pro either.

David Jenkins
-------------------------------------------------------------
Do you want to make extra money around your commitments?
Credit cards, bills, loans and a mortgage - all getting you down?
Is your pension going to be enough when you retire?
There is a solution visit http://www.1stmillion.co.uk
or call 01772 489521