i have a string Series = "C423S539L12332K656GN"
i want to find out the result for C, S, L, K and G
and the result should be
C = 423
S = 539
L = 12332
K = 656
G = N

and here is what i did:

        C = Mid(Series, InStr(Series, "C") + 1, InStr(Series, "S") - 2)
        S = Mid(Series, InStr(Series, "S") + 1, InStr(Series, "L") - (InStr(Series, "S") + 1))
        L = Mid(Series, InStr(Series, "L") + 1, InStr(Series, "K") - (InStr(Series, "L") + 1))
        K = Mid(Series, InStr(Series, "K") + 1, InStr(Series, "G") - (InStr(Series, "K") + 1))
        G = Right(Series, 1)


my question is do way have any shorter way to get the same result ?
thanks

You could probably do this using a regular expression to split the string. Something along the lines of:

Regex r=new Regex("[A-Z]+[0-9]+");
string Series="C423S539L12332K656GN";
String[] myStringSplit=r.Split(Series);

This will create a regular expression that looks for one or more captial letters followed by one or more numbers, then split the series string on each match into a string array called myStringSplit.

The regular expression may be wrong, I didn't have time to test this and its not my strong point :-)

Hope this helps!

A regular expresion would be more slow than your aproach... what do you mean by shorter way?? less code???

HTH

Gonzalo

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
^^Took that from dparsons signature and he Took that from planoie's profile
================================================== =========
My programs achieved a new certification (can you say the same?):
WORKS ON MY MACHINE
http://www.codinghorror.com/blog/archives/000818.html
================================================== =========
I know that CVS was evil, and now i got the proof:
http://worsethanfailure.com/Articles...-Hate-You.aspx
================================================== =========

what do you mean by shorter way?? less code??? -> less code and faster load
thanks

well.. a good idea will be to replace mid and instr with string functions, look into the string class to find what you need... and less code doesn't mean that the load will be faster.. you can writte all the code in one line and it could be slower than this...

HTH

Gonzalo

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
^^Took that from dparsons signature and he Took that from planoie's profile
================================================== =========
My programs achieved a new certification (can you say the same?):
WORKS ON MY MACHINE
http://www.codinghorror.com/blog/archives/000818.html
================================================== =========
I know that CVS was evil, and now i got the proof:
http://worsethanfailure.com/Articles...-Hate-You.aspx
================================================== =========

hmmm one approach would be:

string[] arrValues = Series.Split(new char[] {'C', 'S', 'L', 'K', 'G'});

Your array now looks like this:
arrValues[0] = 423
arrValues[1] = 539
arrValues[1] = 12332
arrValues[3] = 656
arrValues[4] = N

hth

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
================================================== =========
Technical Editor for: Professional Search Engine Optimization with ASP.NET
http://www.wiley.com/WileyCDA/WileyT...470131470.html
================================================== =========
Why can't Programmers, program??
http://www.codinghorror.com/blog/archives/000781.html
================================================== =========