Using class reference getting error

rojiin · July 5th, 2007, 11:45 PM

i am using a class(newuser.cs)for inserting username, the code i had use is below

/* Newuser.cs */
public class Newuser
{
    SqlConnection sqlcon = new SqlConnection(ConfigurationManager.AppSettings["sqlcon"]);

    public void adduser(insertuser user)
    {
       SqlCommand cmd = new SqlCommand("login",sqlcon);
       cmd.CommandType = CommandType.StoredProcedure;

        cmd.Parameters.Add("@username", SqlDbType.Char);
        cmd.Parameters["@username"].Direction = ParameterDirection.Input;
        cmd.Parameters["username"].Value = user.username;

     }
}

public class insertuser

{
  public string username
        {
            get
            {
                return username;
            }

            set
            {
                username = value;
            }
        }
}

and i am calling this class in the button click event

/* login.aspx.cs */

protected void btnUpdate_Click(object sender, EventArgs e)
    {
        insertuser add = new insertuser();
        add.username = TextBox1.Text;

    }

but after i entered values in textbox1 and once i clicked on button i am getting this error pointing to username=value. and in messagebox :- An unhandled exception of type System.StackOverflowException' occurred in App_Code.dtsq82es.dll

is there anyone to help me to overcome from this problem.please tell me how i can able to get the username to my database.

Thanking you

gbianchi · July 6th, 2007, 07:59 AM

hi there...

the compiler is right.. you have an stack overflow because you are using the property in a bad way... if you don't store the value of the property in a variable, there will be eternal calls to the property...

Code:

public string username
        {
            get
            {
                return username;
            }

            set
            {
                username = value;
            }
        }

this is your property..

username is the name of the property.. and also is where you are storing the new value.. since they have the same name, when you pass a value to username something like this happens..

username get's a value, username call username get property to store it, username get's a value, username call itself (again) get property to store it, and again and again...

you have to store the value in another variable... something like this...

Code:

private string username
public string Username
        {
            get
            {
                return username;
            }

            set
            {
                username = value;
            }
        }

remember that C# is case sensitive...

HTH

Gonzalo

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
^^Took that from dparsons signature and he Took that from planoie's profile
================================================== =========
My programs achieved a new certification (can you say the same?):
WORKS ON MY MACHINE
http://www.codinghorror.com/blog/archives/000818.html
================================================== =========
I know that CVS was evil, and now i got the proof:
http://worsethanfailure.com/Articles...-Hate-You.aspx
================================================== =========

planoie · July 6th, 2007, 01:53 PM

If you follow a good naming convention, these problems are encountered much less often. A lot of people elect to prefix class scope variables with an underscore. I also like to use some form of prefix notation to make reading the code easier.

Code:

private string _strUsername;
public string Username
        {
            get{ return _strUsername; }
            set{ _strUsername = value; }
        }

-Peter