I am having problems populating my label with the return valueof a stored procedure.

This is the error I am getting:

String[1]: the Size property has an invalid size of 0.

EDIT: i changed the value of my varchar to 255 and now get the error:

Conversion failed when converting the varchar value 'test3 has been submitted successfully' to data type int.

I think it has to do with how i am converting the varchar to string but i am not sure.

My stored procedure:

ALTER PROCEDURE [dbo].[Add_Addresstype]
    -- Add the parameters for the stored procedure here
        @t_Addresstype VarChar(50),
        @t_return VarChar(255) OUTPUT

AS
BEGIN
    IF EXISTS (SELECT t_AddressType From CM_AddressType WHERE t_AddressType = @t_Addresstype)
BEGIN
    SET @t_return = 'The Address Type ' + @t_AddressType + ' already exists!'
    RETURN @t_return
END
ELSE
BEGIN
    INSERT INTO CM_AddressType (t_addresstype) VALUES (@t_AddressType)
    Set @t_return = @t_AddressType + ' has been submitted successfully'
    RETURN @t_return
END
END


the code i am using in c#

SqlConnection CRMConnectionString = new SqlConnection("Data Source=IRIS2;Initial Catalog=CRM;Persist Security Info=True;User ID=client;Password=w3bcl13nt");
        SqlCommand cmd = new SqlCommand("Add_AddressType", CRMConnectionString);
        cmd.CommandType = CommandType.StoredProcedure;
        cmd.Parameters.AddWithValue("@t_AddressType", txtAddressType.Text);
        cmd.Parameters["@t_AddressType"].Value = txtAddressType.Text;
        cmd.Parameters.Add(new SqlParameter("@t_return", SqlDbType.VarChar, 255));
        cmd.Parameters["@t_return"].Direction = ParameterDirection.Output;
        CRMConnectionString.Open();
        cmd.ExecuteNonQuery();
        CRMConnectionString.Close();
        string t_return = cmd.Parameters["@t_return"].Value.ToString();
        lblreturn.Text = t_return;

hi there.. what if you add the parameter @t_AddressType as a varchar too?? because you are not defining it when you pass the parameters...


HTH

Gonzalo

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
^^Took that from dparsons signature and he Took that from planoie's profile
================================================== =========
My programs achieved a new certification (can you say the same?):
WORKS ON MY MACHINE
http://www.codinghorror.com/blog/archives/000818.html
================================================== =========
I know that CVS was evil, and now i got the proof:
http://worsethanfailure.com/Articles...-Hate-You.aspx
================================================== =========

Thanks for your response. The insert of the text box entry is working but the return value of @t_return is failing with this error message:

"Conversion failed when converting the varchar value 'test5 has been submitted successfully' to data type int."

I am sorry if i missed the solution in your post. I am very new and dont always understand.

no problem.. what I see, is that somebody is casting that string to a int data type... (nothing new that you don't already knew).. anyway.. let's try figure out who is converting it... the error is on the SP or in your code?? what line throws it??

HTH

Gonzalo

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
^^Took that from dparsons signature and he Took that from planoie's profile
================================================== =========
My programs achieved a new certification (can you say the same?):
WORKS ON MY MACHINE
http://www.codinghorror.com/blog/archives/000818.html
================================================== =========
I know that CVS was evil, and now i got the proof:
http://worsethanfailure.com/Articles...-Hate-You.aspx
================================================== =========

Oh okay I think i see what your saying

 cmd.Parameters.Add(new SqlParameter("@t_return", SqlDbType.VarChar, 255));

This is the line that is defining it as int?

How would I make it Varchar? I thought this code
string t_return = cmd.Parameters["@t_return"].Value.ToString();
converted the varchar ToString ?

I also thought that c# didnt have varchar and i had to use string?

that line define it as a varchar..

that code transform the object to a string.. maybe the object there is not a string??

I ask again.. which line is throwing the error????
if you trace the code.. where the compiler informs you of the error???

HTH

Gonzalo

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
^^Took that from dparsons signature and he Took that from planoie's profile
================================================== =========
My programs achieved a new certification (can you say the same?):
WORKS ON MY MACHINE
http://www.codinghorror.com/blog/archives/000818.html
================================================== =========
I know that CVS was evil, and now i got the proof:
http://worsethanfailure.com/Articles...-Hate-You.aspx
================================================== =========

the line that is highlighted is when i debug and press my button is

 cmd.ExecuteNonQuery();

is that what i am looking for. sorry again?

I'm not an SP expert.. but maybe SQL is trying to map the return value to an int because executenonquery return the number of row affecteds??? what if you take out the return lines from the SP????

HTH

Gonzalo

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
^^Took that from dparsons signature and he Took that from planoie's profile
================================================== =========
My programs achieved a new certification (can you say the same?):
WORKS ON MY MACHINE
http://www.codinghorror.com/blog/archives/000818.html
================================================== =========
I know that CVS was evil, and now i got the proof:
http://worsethanfailure.com/Articles...-Hate-You.aspx
================================================== =========

OMG your so smart!! I commented out the RETURN lines and the output worked properly!! i get my message back and everything. any other suggestions you might be have regarding my code is welcomed. thank you so much!!

glad you solve it :)

HTH

Gonzalo

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
^^Took that from dparsons signature and he Took that from planoie's profile
================================================== =========
My programs achieved a new certification (can you say the same?):
WORKS ON MY MACHINE
http://www.codinghorror.com/blog/archives/000818.html
================================================== =========
I know that CVS was evil, and now i got the proof:
http://worsethanfailure.com/Articles...-Hate-You.aspx
================================================== =========