When I enter any non-integer value into the txtPriceQuoted text box, I get the error "Syntax error converting the varchar value '1.25' to a column of data type int". Within the database, the PriceQuoted field is varchar(50) and defined as such in the stored procedure. I am not trying to convert that value anywhere, so why the error?


        protected void lnkSave_Click(object sender, System.EventArgs e)
        {

            string connString = ConfigurationManager.ConnectionStrings["crConnString"].ConnectionString;
            SqlConnection cn = new SqlConnection(connString);
            SqlCommand cmdUpd = new SqlCommand("Save_sp", cn);
            cmdUpd.CommandType = CommandType.StoredProcedure;

            if (rdbVirtualNo.Checked)
            {
                cmdUpd.Parameters.Add(new SqlParameter("@PricingQuotedFlag", false));
                cmdUpd.Parameters.Add(new SqlParameter("@PriceQuoted", ""));
                cmdUpd.Parameters.Add(new SqlParameter("@PriceApprover", ""));
            }
            else
            {
                cmdUpd.Parameters.Add(new SqlParameter("@PricingQuotedFlag", true));
                cmdUpd.Parameters.Add(new SqlParameter("@PriceQuoted", txtPriceQuoted.Text));
                cmdUpd.Parameters.Add(new SqlParameter("@PriceApprover", txtApproverName.Text));
            }

            cmdUpd.Connection.Open();
            cmdUpd.ExecuteNonQuery();
            cmdUpd.Connection.Close();
            Response.Redirect("DetCr.aspx?CrID=" + Request.QueryString["CrID"]);
        }

Can you post the stored procedure? I suspect that you are trying to compare the @PriceQuoted procedure argument to a table column that IS of type INT. You'll need to convert at some point.

-Peter

CREATE PROC dbo.Save_sp

@CrID int,
@PricingQuotedFlag bit,
@PriceQuoted varchar(50),
@PriceApprover varchar(100)

IF EXISTS(SELECT CrID FROM Cr WHERE CrID = @CrID)
BEGIN
        UPDATE Cr SET PricingQuotedFlag = @PricingQuotedFlag, PriceQuoted = @PriceQuoted, PriceApprover = @PriceApprover

        WHERE CrID = @CrID
END
GO

What type is the Cr.PriceQuoted field? Varchar(50)?

And you could try to use

cmdUpd.Parameters.AddWithValue("PriceQuoted", txtPriceQuoted.Text);

instead of Parameters.Add(new SqlParameter ... ) thingy.

Yes, Cr.PriceQuoted is varchar(50)

addwithvalue gives the same error

This line is jumping out at me:

   IF EXISTS(SELECT CrID FROM Cr WHERE CrID = @CrID)

Where are you adding the @CrID parameter to the command object? I don't see it in your posted code. How are you adding it if you are? It's possible that this is the problem. One of the values in this part (CrID = @CrID) of the above line is an integer and the other is not. The database engine can not implicitly convert an INT into a character/string value.

-Peter