Hi everybody,

I have a javascript code that works well in html but I could not make it work in aspx file.

I have registered the javascript function first:

    Protected Sub Page_Load(.....) Handles Me.Load
        Me.addScriptToPage()
    End Sub

    Private Sub addScriptToPage()
        Dim script As String = "<script language='JavaScript'>"
        script &= "function changeImage(filename){"
        script &= "document.mainimage.src = filename;}"
        script &= "</script>"

        If Not (Me.IsClientScriptBlockRegistered("scriptBlok")) Then
            Me.RegisterClientScriptBlock("scriptBlok", script)
        End If
    End Sub

Then I called this function in this way:

Response.Write("<a href=javascript:changeImage(" & "'C:\matilda01.jpg'" & ")>MyImage</a>")

There is a image on the page called "mainimage" on which other images will be displayed by using changeImage function.. But it did not work..

Have you noticed any missing points???

I can't say I see anything wrong with the javascript itself, however there is one major problem which might not be immediately apparent:

You are providing an explicit *local* file page for an image. This will only work on your machine. Any other user browsing your site won't see "C:\matilda01.jpg" unless they happen to have a copy of it on their local PC.

-Peter

Response.Write("<a href=javascript:changeImage(" & "'C:\matilda01.jpg'" & ")>MyImage</a>")

I think there could be problem with this line.
Do you think that is the syntax correct in the code line above?

Generally, you should try to enclose attribute values in quotes. Is the image going to be hard coded on this line? If so you are performing an unnecessary concatenation.

Response.Write("<a href=""javascript:changeImage('C:\matilda01.jpg')" ">MyImage</a>")

Note the two double quotes. That escapes the " character in VB.Net.

-Peter

In addition to what Peter said, you may want to stay clear from using Response.Write.

Depending on where you call it, the output of Response.Write may end up outside (above) the opening HTML tag, as the page hasn't begun outputting HTML yet.

Instead, add a Literal to your page and assign the text / script to the Literal's Text property.

Cheers,

Imar

---------------------------------------
Imar Spaanjaars
http://Imar.Spaanjaars.Com
Everyone is unique, except for me.
Author of ASP.NET 2.0 Instant Results and Beginning Dreamweaver MX / MX 2004