DetailsView update not working.

Andrew.Berry · April 18th, 2008, 10:31 AM

Hi all,

I have a detailsview that I am trying to implement update functionality, but am having some issues:

Here's the code:

Code:

 <asp:SqlDataSource ID="SqlDataSource1" runat="server" ConnectionString="<%$ ConnectionStrings:relOUPConnectionString %>"
            SelectCommand="SELECT * FROM [OUP_SAPData]" OldValuesParameterFormatString="original_{0}" ConflictDetection="CompareAllValues" 

UpdateCommand="UPDATE [OUP_SAPData] SET [JobNo] = @JobNo, [GL_AccCode] = @GL_AccCode, 
[CostCentre] = @CostCentre, 
[SAPFirstCostOrderNo] = @SAPFirstCostOrderNo, 
[ISBN] = @ISBN, [SAPPONum] = @SAPPONum, 
[POConditionType] = @POConditionType 
WHERE [ID] = @original_ID AND 
[JobNo] = @original_JobNo AND 
[GL_AccCode] = @original_GL_AccCode AND
 [CostCentre] = @original_CostCentre AND
 [SAPFirstCostOrderNo] = @original_SAPFirstCostOrderNo AND
 [ISBN] = @original_ISBN AND 
[SAPPONum] = @original_SAPPONum AND 
[POConditionType] = @original_POConditionType">


            <DeleteParameters>
                <asp:Parameter Name="original_ID" Type="Int32" />
                <asp:Parameter Name="original_JobNo" Type="String" />
                <asp:Parameter Name="original_GL_AccCode" Type="String" />
                <asp:Parameter Name="original_CostCentre" Type="String" />
                <asp:Parameter Name="original_SAPFirstCostOrderNo" Type="String" />
                <asp:Parameter Name="original_ISBN" Type="String" />
                <asp:Parameter Name="original_SAPPONum" Type="String" />
                <asp:Parameter Name="original_POConditionType" Type="String" />
            </DeleteParameters>
            <UpdateParameters>
                <asp:Parameter Name="JobNo" Type="String" />
                <asp:Parameter Name="GL_AccCode" Type="String" />
                <asp:Parameter Name="CostCentre" Type="String" />
                <asp:Parameter Name="SAPFirstCostOrderNo" Type="String" />
                <asp:Parameter Name="ISBN" Type="String" />
                <asp:Parameter Name="SAPPONum" Type="String" />
                <asp:Parameter Name="POConditionType" Type="String" />
                <asp:Parameter Name="original_ID" Type="Int32" />
                <asp:Parameter Name="original_JobNo" Type="String" />
                <asp:Parameter Name="original_GL_AccCode" Type="String" />
                <asp:Parameter Name="original_CostCentre" Type="String" />
                <asp:Parameter Name="original_SAPFirstCostOrderNo" Type="String" />
                <asp:Parameter Name="original_ISBN" Type="String" />
                <asp:Parameter Name="original_SAPPONum" Type="String" />
                <asp:Parameter Name="original_POConditionType" Type="String" />
            </UpdateParameters>
            <InsertParameters>
                <asp:Parameter Name="JobNo" Type="String" />
                <asp:Parameter Name="GL_AccCode" Type="String" />
                <asp:Parameter Name="CostCentre" Type="String" />
                <asp:Parameter Name="SAPFirstCostOrderNo" Type="String" />
                <asp:Parameter Name="ISBN" Type="String" />
                <asp:Parameter Name="SAPPONum" Type="String" />
                <asp:Parameter Name="POConditionType" Type="String" />
            </InsertParameters>
        </asp:SqlDataSource>

Now I can't see what i'm missing here. Any thoughts?

Imar · April 18th, 2008, 10:37 AM

Quote:

quote:Now I can't see what i'm missing here

The error message or problem description maybe? ;)

Can you please add line breaks in your code? This is near to impossible to read....

Imar

---------------------------------------
Imar Spaanjaars
http://Imar.Spaanjaars.Com
Everyone is unique, except for me.
Author of Beginning ASP.NET 3.5 : in C# and VB, ASP.NET 2.0 Instant Results and Dreamweaver MX 2004
Want to be my colleague? Then check out this post.

Andrew.Berry · April 18th, 2008, 10:58 AM

I get no errors, it returns to the page as expected, but doesn't update the details.

Imar · April 19th, 2008, 07:26 AM

Hi Andew,

Difficult to tell without the ability to try it out, or seeing other parts of your code.

Maybe the error is caused by the ConflictDetection? Maybe some fields are null, or get lost when the DetailsView posts back so the WHERE clause never finds the right record to update? To see if that's the problem, change the WHERE to:

WHERE [ID] = @original_ID

Also, make sure the DetailsView is set up correctly and uses the right keys and columns.

HtH,

Imar

---------------------------------------
Imar Spaanjaars
http://Imar.Spaanjaars.Com
Everyone is unique, except for me.
Author of Beginning ASP.NET 3.5 : in C# and VB, ASP.NET 2.0 Instant Results and Dreamweaver MX 2004
Want to be my colleague? Then check out this post.

Andrew.Berry · April 22nd, 2008, 10:17 AM

Found the problem.

The reason it wasn't updating the entry was that in the DetailsView, I wasn't displaying the id (primary key) so the row in the table wasn't updating.

Do you know of any way to be able to update the row without having to display the id? It's not a major issue, I just would rather not have to show it...

Cheers for your help.

Imar · April 22nd, 2008, 10:34 AM

Did you set the DataKeyNames property of the DetailsView to the primary key(s) of the record in the database?

Imar
---------------------------------------
Imar Spaanjaars
http://Imar.Spaanjaars.Com
Everyone is unique, except for me.
Author of Beginning ASP.NET 3.5 : in C# and VB, ASP.NET 2.0 Instant Results and Dreamweaver MX 2004
Want to be my colleague? Then check out this post.

Andrew.Berry · April 22nd, 2008, 11:23 AM

No I haven't....yet!

Will look that up and keep you posted, cheers!