Delete record but how?

scifo · August 1st, 2003, 06:43 AM

I have another problem now. I cannot delete a record in table âdoctorsâ. The name of the field that I specify is âdoctorâ. My code is here:
<html>
<head>
<title>Deleting Record</title> </head>
<body>
<?php
// Set the variables for the database access:
$Host = "***";
$DBName = "***";
$TableName = "Doctors";
$Link = mysql_connect ($Host, '***', '***'); if ($Link==false) {
echo mysql_errno().": ".mysql_error()." \n";
}
mysql_select_db ($DBName, $Link); $Query = "DELETE FROM $Tablename WHERE Doctor = "ppp""; if (mysql_query ($Query, $Link)) {
print "The query was successfully executed! \n"; }
else { print "The query could not be executed! \n";
print mysql_errno().": ".mysql_error()." \n"; }
?>
</body> </html> I receive the error message
Parse error: parse error in c:\***\***\***\deleterow.php on line 17
Line 17 is: $Query = "DELETE FROM $Tablename WHERE Doctor = "ppp"";
When I change that line to
$Query = "DELETE FROM $Tablename WHERE Doctor = âpppâ";
I receive this error message:
Warning: Undefined variable: Tablename in c:\***\***\***\deleterow.php on line 17
The query could not be executed!
1064: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE Doctor = 'ppp'' at line 1

I could not understand what is wrong here. Help me pls.

MEG

scifo · August 1st, 2003, 10:20 AM

SORTED Thanx.

richard.york · August 1st, 2003, 11:56 AM

You have another problem with quotes.

$Query = "DELETE FROM $Tablename WHERE Doctor = 'ppp'"

If you are using double quotes around the outer string, then you should use single quotes around the inner strings which construct the SQL syntax.

Variable names are also case sensitive,

So if you are using $Tablename in the query command, it isn't the same as $TableName as you have it defined.

: )
Rich

:::::::::::::::::::::::::::::::::
Smiling Souls
http://www.smilingsouls.net
:::::::::::::::::::::::::::::::::

richard.york · August 1st, 2003, 12:14 PM

Also, some observations:
Your code is hard to sort through when it isn't formatted to be pleasant to the eye, indent your code - or at the very least double space it!

Stay consistent with your variable names! I think capitalization is a bad idea, because then if you misspell a variable, you're all day trying to figure out what went wrong. As was the case in $Tablename. I like all lowercase with underscores to separate words. But that's just me. Pick a standard and stay with it.

Code:

<?php
// Set the variables for the database access:

$Host = "***";
$DBName = "***";
$TableName = "Doctors";
$Link = mysql_connect ($Host, '***', '***'); 

     if ($Link==false) {

          echo mysql_errno().": ".mysql_error()."<br />\n";

     }

mysql_select_db ($DBName, $Link); 
$Query = "DELETE FROM $Tablename WHERE Doctor = "ppp""; 

if (mysql_query ($Query, $Link)) {

     print "The query was successfully executed!<br />\n"; 

} else {      

    print "The query could not be executed!<br />\n";
    print mysql_errno().": ".mysql_error()."<br />\n"; 

} 

?>

The tag that you use is also deprecated under HTML 4.01. Deprecated means slated for deletion from the standard. Under a strict docutype setting that tag should fail.

See this article on how to do it right:
http://p2p.wrox.com/topic.asp?TOPIC_ID=2251

: )
Rich

:::::::::::::::::::::::::::::::::
Smiling Souls
http://www.smilingsouls.net
:::::::::::::::::::::::::::::::::