Parse error on line that does not exist

shabboleth · December 19th, 2003, 12:32 PM

Hello all,

I am getting a parse error on line 53 of a PHP document that vi shows as only having 52 lines. I am very new to PHP so I am sure it is something simple. Any help will be greatly appreciated.

Thanks,

Glen

Here is the document:

<?php
        $link = mysql_connect("localhost","user","password");
        $query = "SELECT * FROM jpnquiz.users";
        $result = mysql_query($query);
        $query_data = mysql_fetch_array($result);
?>
<html>
<head></head>
<body bgcolor="white" background="hiragana_bg.jpg">
<br>
<br>
<br>
<br>
<table border="1" align="center" width="50%">
<tr>
<td width="100%" align="center" bgcolor="white"><strong> Please select your name or enter the name by which you would like to be addressed.</td>
</tr>
</table>
<br>
<br>
<br>
<form method="post" action="savenewuser.php">
<table border="0" align="center" width="50%">
<?php
        If($query_data)
        {
        echo "<tr><td width=\"";
        echo "100%\" align=\"center\"><select name=\"selectuser\"><option value=\" \"> </option>";
        while($query_data=mysql_fetch_array($result))
        {
        echo "<option value = \"";
        echo $query_data["username"];

        echo "\">";
        echo $query_data["username"];
        echo "</option>";
        }
        echo "</select></td></tr>";
?>
<tr>
<td width="100%" align="center"><input type="text" size="20" maxlength="20" name="username"></td>
</tr>
<tr>
<td width="100%" align="center"> </td>
</tr>
<tr>
<td width="100%" align="center"><input type="submit" value="Save"></td>
</tr>
</table>
</form>
</body>
</html>

nikolai · December 19th, 2003, 01:41 PM

Well, you've got two open-curly-braces, but only one closing brace. PHP issues an error after the last line because the end of the file had been reached and the matching closing curly-brace was never found.

Open curly braces are on lines 26 and 30. Your only closing curly brace is on line 37.

Errors like this are almost always detected if you're more consistent with your indentation and formatting. Here's your code, reformatted:

<?php

if($query_data)
{
    echo "<tr><td width=\"";
    echo "100%\" align=\"center\"><select name=\"selectuser\"><option value=\" \"> </option>";

    while($query_data=mysql_fetch_array($result))
    {
        echo "<option value = \"";
        echo $query_data["username"];
        echo "\">";
        echo $query_data["username"];
        echo "</option>";
    }

    echo "</select></td></tr>";

?>

If this were properly nested, there'd be a closing curly-brace at column 0 (i.e. no indentation). After looking at the code, I think you need a closing curly-brace after your echo "</select>" line (line 39).

Take care,

Nik
http://www.bigaction.org/