I have a parse error and I can't figure what's wrong. i assume its a syntax error but I just don't see it. Here's the error:

Parse error: parse error, unexpected T_IF, expecting ',' or ';' in C:\Program Files\Abyss Web Server\htdocs\phpdemo\stereo2.php on line 10

Here's my code:

<?

function sex2Dec() {

// SEXAGESIMAL TO DECIMAL
//declare variables to be available inside of function
global $AString, $A1, $A2, $A3, $R1

//save sign
if ($AString < 0) {
    $Sign = -1;
    }

if ($AString > 0) {
    $Sign = 1;
    }

$A1=abs($AString);

//calculate??
$A=$Sign*($A1+$A2/60+$A3/3600);
return($A);

}

//start of code
$T = sex2Dec()*15*$R1-$Lat;

?>

Line 10 is in the middle of the if statement but it looks okay to me. Can any one see what I am doing wrong?

Thanks!

This line is missing a semi-colon:

global $AString, $A1, $A2, $A3, $R1

: )
Rich

:::::::::::::::::::::::::::::::::
Smiling Souls
http://www.smilingsouls.net
:::::::::::::::::::::::::::::::::

Food for thought -- $Sign is never initialized if $AString is equal to zero. This will cause a NOTICE level warning on PHP installations where error_reporting is set to report these warnings. (E_ALL, the default setting, would complain about this).

Suggested replacement: how about this?

$Sign = ($AString < 0)? -1 : 1;


Also, it's not really good programming style to have a function only operate on global variables. It totally limits the usefulness of the function because you can't just use it in another application. You should pass all the data to the function as parameters.

Finally, you create a variable, $A, to hold the result of your calculations, but all you do with $A is return it. It makes more sense to NOT create the variable and just return the result of the calculation directly. It's a little more streamlined, since you don't have to allocate memory for a variable that you're just going to free up anyway.

  return $Sign * ($A1 + $A2/60 + $A3/3600);


Take care,

Nik
http://www.bigaction.org/

Missing semi-colon! Typical, thanks for pointing it out.

Thanks for the ideas, I'll try to work them in.