Undefined offset error agoTimeFormat class

farwall.ghost · June 8th, 2013, 04:14 AM

Quote:

Hi Everyone,
i am creating agoTimeFormat class in php but i am getting error in line 16 and 17, here is my code.

PHP Code:


			
<?php

class convertToAgo {



function convert_datetime($str) {

            list($date, $time) = explode(' ', $str);

        list($year, $month, $day) = explode('-', $date);

        list($hour, $minute, $second) = explode(':', $time);

        $timestamp = mktime($hour, $minute, $second, $month, $day, $year);

        return $timestamp;

}



function makeAgo($timestamp){

           $difference = time() - $timestamp;

           $periods = array("sec", "min", "hr", "day", "week", "month", "year", "decade");

           $lengths = array("60","60","24","7","4.35","12","10");

           for($j = 1; $difference >= $lengths[$j]; $j++)

               $difference /= $lengths[$j];

               $difference = round($difference);

           if($difference != 1) $periods[$j].= "s";

               $text = "$difference $periods[$j] ago";

               return $text;

}

}

?>

Quote:

OUTPUT WITH ERROR:
Notice: Undefined offset: 7 in C:\xampp\htdocs\class\agoTimeFormat.php on line 16

Notice: Undefined offset: 7 in C:\xampp\htdocs\class\agoTimeFormat.php on line 17

Warning: Division by zero in C:\xampp\htdocs\class\agoTimeFormat.php on line 17

Notice: Undefined offset: 8 in C:\xampp\htdocs\class\agoTimeFormat.php on line 16
...
...
...
Notice: Undefined offset: 18208 in C:\xampp\htdocs\class\agoTimeFormat.php on line 17

Warning: Division by zero in C:\xampp\htdocs\class\agoTimeFormat.php on line 17

Notice: Undefined offset: 18209 in C:\xampp\htdocs\class\agoTimeFormat.php on line 16

Notice: Undefined offset: 18209 in C:\xampp\htdocs\class\agoTimeFormat.php on line 17

Fatal error: Maximum execution time of 30 seconds exceeded in C:\xampp\htdocs\class\agoTimeFormat.php on line 17

plz help i m getting 20k error, Thanks

UseLess · June 11th, 2013, 03:24 AM

Greetings,

Fixed:

Code:

<?php

class convertToAgo
{

	function convert_datetime($str)
	{
		list($date, $time) = explode(' ', $str);
		list($year, $month, $day) = explode('-', $date);
		list($hour, $minute, $second) = explode(':', $time);
		$timestamp = mktime($hour, $minute, $second, $month, $day, $year);

		return $timestamp;
	}

	function makeAgo($timestamp)
	{
		$difference = time() - $timestamp;

		$periods = array("sec", "min", "hr", "day", "week", "month", "year", "decade");
		$lengths = array("60","60","24","7","4.35","12","1","10");

		$text = '';
		for($j = 0; $difference >= $lengths[$j] && $j < count($lengths)-1; $j++)
		{
			$difference /= $lengths[$j];
		}

		$difference = round($difference);

		if($difference != 1)
		{
			$periods[$j].= "s";
		}

		$text = "$difference $periods[$j] ago<br />";

		return $text;
	}
}

$ago = new convertToAgo();

// Specify date which should be in YYYY-MM-DD HH:MM:SS format
$date = '1972-04-14 17:10:33';

// create the timestamp for the specified date
$ts = $ago->convert_datetime($date);

// do conversion
echo $ago->makeAgo($ts);

?>

farwall.ghost · June 11th, 2013, 04:30 AM

Quote:

-12597 secs ago

its gives in negative value. Why?

PHP Code:


			
-12597 secs ago



its gives in negative value. Why?

UseLess · June 11th, 2013, 04:43 AM

Greetings,

No it's not the same error.

You're getting a negative value because the date/time is in the future.

For example using:

Code:

2013-06-11 10:10:33

on the 11-06-2013 at 09:38 results in: -1999 secs ago

But using:

Code:

2013-04-11 10:10:33

on the 11-06-2013 at 09:40 results in: 2 months ago

and using:

Code:

2013-06-11 08:10:33

on the 11-06-2013 at 09:41 results in: 2 hours ago

Therefore your class can only handle dates/times in the past if you want it to handle future dates/times you'll need to cater for this.

farwall.ghost · June 11th, 2013, 05:12 AM

PHP Code:


			
so what is the actual solution.

UseLess · June 11th, 2013, 06:45 AM

Greetings,

Change the function to test the timestamp to see if it's greater than the current time if it is take the timestamp away from the current time and set a string to be 'ago' <else> take the current time away from the timestamp and set the string to be 'from now' for example.

farwall.ghost · June 11th, 2013, 01:06 PM

PHP Code:


			
i think i have used DATETIME datatype instead of using TIMESTAMP type in sql while creating fields in table.



is this so?

UseLess · June 12th, 2013, 02:32 AM

Greetings,

And we would know you've used the wrong datatype how?

And you alter the function like this;

Code:

	function makeAgo($timestamp)
	{
		$now = time();

		if( $now > $timestamp )
		{
			$difference = $now - $timestamp;
			$string = 'ago';
		}
		else
		{
			$difference = $timestamp - $now;
			$string = 'from now';
		}

		$periods = array("second", "minute", "hour", "day", "week", "month", "year", "decade");
		$lengths = array("60","60","24","7","4.35","12","10");

		for($j = 0, $j_end = count($lengths)-1; $difference >= $lengths[$j] && ($j < $j_end); $j++)
		{
			$difference /= $lengths[$j];
		}

		$difference = round($difference);

		$interval = $periods[$j] . ( ($difference != 1) ? 's' : '');

		$text = "$difference $interval {$string}<br />";

		return $text;
	}

farwall.ghost · June 16th, 2013, 02:38 AM

PHP Code:


			
well, Thanks for help,



i got error of negative value in localhost only when i uploaded it to internet its working perfactly

thanks