i don't understand this part of the stored procedure
ELSE
BEGIN
    IF NOT EXISTS (SELECT 1 FROM Application WHERE Description = @description AND Id <> @id)
    BEGIN
        UPDATE Application SET
        Description = @description,
        IsActive = @isActive
        WHERE Id = @id

        SELECT @returnValue = @id
    END
    ELSE
    BEGIN
        SELECT @returnValue = -1 -- item already exists
    END
END

are we making sure that there are no dup record by using the AND Id <> @id? what if we have dups?

Hi there,

Yes correct. This code checks that the new Description of the item being updated does not conflict with an existing one. Since updating itself is fine, should should check for Id <> @id to filter all records other than the current one being updated.

Imar


---------------------------------------
Imar Spaanjaars
http://Imar.Spaanjaars.Com
Everyone is unique, except for me.
Author of ASP.NET 2.0 Instant Results and Beginning Dreamweaver MX / MX 2004

Ok thanks I got it

Hi there,

I am not sure what you are asking. Why would there be a duplicate record? The whole idea in the procedure, for Insert and Updates is to prevent them in the first place.....

Can you elaborate a little bit??

Imar


---------------------------------------
Imar Spaanjaars
http://Imar.Spaanjaars.Com
Everyone is unique, except for me.
Author of ASP.NET 2.0 Instant Results and Beginning Dreamweaver MX / MX 2004

Sorry Imar I was confused about the way you wrote the stored procedure but now I'm not. But I still want know one thing, why you used the sp's return value to return the id? why not using an output parameter?

Return values are a little easier to work with; However, an output parameter is a good choice too.

Imar

---------------------------------------
Imar Spaanjaars
http://Imar.Spaanjaars.Com
Everyone is unique, except for me.
Author of ASP.NET 2.0 Instant Results and Beginning Dreamweaver MX / MX 2004

ok thanks