Error in BLL.Article.Article.cs

drohm · August 14th, 2006, 12:44 AM

I believe there is an error in the code in the Article.cs file in the BLL layer for the GetArticleCount(bool publishedOnly) method. The original method reads:

Code:

      /// <summary>
      /// Returns the number of total published articles
      /// </summary>
      public static int GetArticleCount(bool publishedOnly)
      {
         if (publishedOnly)
            return GetArticleCount();

         int articleCount = 0;
         string key = "Articles_ArticleCount_" + publishedOnly.ToString();

         if (BaseArticle.Settings.EnableCaching && BizObject.Cache[key] != null)
         {
            articleCount = (int)BizObject.Cache[key];
         }
         else
         {
            articleCount = SiteProvider.Articles.GetPublishedArticleCount(DateTime.Now);
            BaseArticle.CacheData(key, articleCount);
         }
         return articleCount;            
      }

The problem I'm having is that when I pass in true to get the count for only published articles, its calling GetArticleCount, which returns the total number of articles, regardless of whether the article is published or not. If you pass in false, it does the exact opposite. I believe the code should read:

Code:

      /// <summary>
      /// Returns the number of total published articles
      /// </summary>
      public static int GetArticleCount(bool publishedOnly)
      {
         if (!publishedOnly)
            return GetArticleCount();

         int articleCount = 0;
         string key = "Articles_ArticleCount_" + publishedOnly.ToString();

         if (BaseArticle.Settings.EnableCaching && BizObject.Cache[key] != null)
         {
            articleCount = (int)BizObject.Cache[key];
         }
         else
         {
            articleCount = SiteProvider.Articles.GetPublishedArticleCount(DateTime.Now);
            BaseArticle.CacheData(key, articleCount);
         }
         return articleCount;            
      }

The only change was made to the first if statement in the method. I simply inserted the NOT symbol to get the expected behavior.

Marco, can you verify that what I'm assuming is correct? Thanks and your book is awesome. Great job!

Douglas Rohm

drohm · August 14th, 2006, 12:49 AM

I also just verified the GetArticleCount(bool publishedOnly, int categoryID) method. Its using the logic I assumed in my previous post, confirming the error.

Code:

      /// <summary>
      /// Returns the number of total published articles for the specified category
      /// </summary>
      public static int GetArticleCount(bool publishedOnly, int categoryID)
      {
         if (!publishedOnly)
            return GetArticleCount(categoryID);

         if (categoryID <= 0)
            return GetArticleCount(publishedOnly);

         int articleCount = 0;
         string key = "Articles_ArticleCount_" + publishedOnly.ToString() + "_" + categoryID.ToString();

         if (BaseArticle.Settings.EnableCaching && BizObject.Cache[key] != null)
         {
            articleCount = (int)BizObject.Cache[key];
         }
         else
         {
            articleCount = SiteProvider.Articles.GetPublishedArticleCount(categoryID, DateTime.Now);
            BaseArticle.CacheData(key, articleCount);
         }
         return articleCount; 
      }

Hope this helps.

Doug

englere · August 14th, 2006, 09:56 AM

Please report this here:

http://www.wrox.com/WileyCDA/WroxTit...ew_errata.html

Click on the link for the "errata form".

Thanks,
Eric