Bug in the highlight method for form objects

cheets · March 6th, 2007, 08:21 AM

Here's the code from Helpers.cs

Code:

      public static void SetInputControlsHighlight(Control container, string className, bool onlyTextBoxes)
      {
         foreach (Control ctl in container.Controls)
         {
            if ((onlyTextBoxes && ctl is TextBox) || ctl is TextBox || ctl is DropDownList ||
                ctl is ListBox || ctl is CheckBox || ctl is RadioButton || 
                ctl is RadioButtonList || ctl is CheckBoxList)
            {
               WebControl wctl = ctl as WebControl;
               wctl.Attributes.Add("onfocus", string.Format("this.className = '{0}';", className));
               wctl.Attributes.Add("onblur", "this.className = '';");
            }
            else
            {
               if (ctl.Controls.Count > 0)
                  SetInputControlsHighlight(ctl, className, onlyTextBoxes);
            }
         }
      }

Now if you look at it, doesn't matter whether onlyTextBoxes is true or false, all form objects will get the onfocus and onblur actions. I have fixed the code to work correctly and here is the correct code:

Code:

    public static void SetInputControlsHighlight(Control container, string className, bool onlyTextBoxes) {
      foreach (Control ctl in container.Controls) {
        if ((!onlyTextBoxes && ( ctl is TextBox || ctl is DropDownList ||
          ctl is ListBox || ctl is CheckBox || ctl is RadioButton ||
          ctl is RadioButtonList || ctl is CheckBoxList)) || (onlyTextBoxes && ctl is TextBox)) {
          WebControl wctl = ctl as WebControl;
          wctl.Attributes.Add("onfocus", string.Format("this.className = '{0}';", className));
          wctl.Attributes.Add("onblur", "this.className = '';");
        }
        else {
          if (ctl.Controls.Count > 0)
            SetInputControlsHighlight(ctl, className, onlyTextBoxes);
        }
      }
    }

Hope it helps someone :) I actually found out also that IE7 does not render onfocus for checkboxes but FF2 does render. I was testing both browsers and found out the highlight on FF2. As I didn't want it I changed the boolean to true at BasePage.cs. But the highlight was still there. Then I investigated the code and now it's fixed to work correctly.

jmartarelli · April 28th, 2009, 01:52 AM

Your code works perfect, tks!!!

Scott663 · April 28th, 2009, 10:53 AM

You may also be interested in the enhancements I added to the Highlight method. If an input control has an existing inline class it will be lost after the control's onfocus/onblur events are fired. The modified code below preserves the controls' original class during both onfocus & onblur events.

One other enhancement is to highlight DropDownLists using the 'onmousedown' event.

Code:

IfTypeOf (ctl) Is DropDownList Then
   'use "onmousedown" for dropdownlist ("onfocus" causes a postback) 
   wctl.Attributes.Add("onmousedown", String.Format("this.className = '{0}';", className))
Else
   'wctl.Attributes.Add("onfocus", String.Format("this.className = ' {0}';", className))
   wctl.Attributes.Add("onfocus", String.Format("this.className = '{0} ' + this.className;", className)) 'fix: preserves current class
EndIf
   wctl.Attributes.Add("onblur", String.Format("this.className = '{0}';", wctl.CssClass)) ' fix: restores original class
   'wctl.Attributes.Add("onblur", "this.className = '';")

Hope this helps, Scott.

damole · June 11th, 2009, 08:05 PM

using it in IE7 and FF2 or any browser, I am not able to get any action on this at all.

I know I miss something, I am assuming I am supposed to set or make reference to the events somewhere other than in the helpers.cs and the basepage.cs files as indicated on page 44 and 45.

does anyone have any clue on the element I am missing?