Caching â please help, Iâm completelly lost

asponmynet · April 14th, 2010, 04:14 PM

hi

Iâm looking at the way Marco implemented caching, and some of the implementation decisions the guy made simply donât make sense to me, and besides feeling really dumb Iâm also afraid that perhaps Iâm missing the big picture. So I would really appreciate if someone could help me with my questions:

1) UpdatePost() method caches the following items:

Code:

BizObject.PurgeCacheItems("forums_unapprovedposts");
         BizObject.PurgeCacheItems("forums_threads");
         BizObject.PurgeCacheItems("forums_threadcount");
         BizObject.PurgeCacheItems("forums_thread_" + id.ToString());
         BizObject.PurgeCacheItems("forums_post_" + id.ToString());

a) Shouldnât we first check whether the updated post is unapproved and only then then purge "forums_unapprovedposts" entry from the cache?
b) Wouldnât purging "forums_threads" make sense only if the updated post was also a main post? So why donât we first check if it is indeed a main post and then purge "forums_threads" entries?
c) I donât see any point in purging "forums_threadcount", since we didnât create a new thread?

2)
InsertPost() method purges:

Code:

if (approved)
         {
            BizObject.PurgeCacheItems("forums_threads");
            BizObject.PurgeCacheItems("forums_thread_" + parentPostID.ToString());            
            BizObject.PurgeCacheItems("forums_threadcount");
         }
         else
            BizObject.PurgeCacheItems("forums_unapprovedposts");

a) Again, doesnât purging "forums_threads" and âforums_threadcountâ only make sense if inserted post is also a main post?

3)
DeletePost() method purges entries:

Code:

BizObject.PurgeCacheItems("forums_unapprovedposts");
         BizObject.PurgeCacheItems("forums_threads");
         BizObject.PurgeCacheItems("forums_threadcount");
         BizObject.PurgeCacheItems("forums_thread_" + id.ToString());
         BizObject.PurgeCacheItems("forums_post_" + id.ToString());

a) But shouldnât we first check whether deleted post is also unapproved, since by checking this, we may not need to also purge "forums_threads", "forums_threadcountâ, "forums_thread_" + id.ToString()" entries, which would save us from quite a few trips to a database?!

4)
CloseThread() method only purges âforums_thread_" + threadPostID.ToString()" and âforums_post_" + threadPostID.ToString()".

a)But shouldnât it also purge âforums_threadsâ and âforums_threadcountâ?

5) Also, wonât MoveThread() cause non-main posts ( belonging to the thread we moved ) to contain invalid data, since their Post.ForumID property wonât return correct result?

6) Why doesnât GetPostCountByThread() method also cache the resulting value?

I would really appreciate some help

asponmynet · April 26th, 2010, 03:17 PM

i realize this little protest will probably be ignored or not even noticed, but I'll moan anyway

Not trying to be provocative mr. Lee Dumond, but since you did reply to threads made after I this one, it appears you didnât reply to my thread because you donât know the answers to my question. Itâs my thread, so I canât be 100% objective, but caching and how to correctly implement it in a web application is one of most important aspects of any web application, so if youâre so inclined to help others with BeerProject related questions, why not also help with caching, especially if the Markoâs implementation appears to be imperfect?
If you donât want to be bothered with more challenging threads, why not make a sticky about it, so we wouldnât get our hopes up and wait perhaps weeks in hopes that mr. Lee will grace us with an answer( which one does if they invest so much time and energy into a website project )?