ItemInserting or ItemInserted?

Imar · August 30th, 2012, 04:49 AM

While this works, it violates the Dry Principle.

Your code is identical in both cases. Move it to a Sub and then call it from both places, Also, in Load, don't load the data after a PostBack. You end up with this:

Code:

   Protected Sub Page_Load(sender As Object, e As System.EventArgs) Handles Me.Load
    
      If Not Page.IsPostBack Then
        BindData()
    End If
   
    End Sub

    Protected Sub DetailsView1_ItemInserted(sender As Object, e As System.Web.UI.WebControls.DetailsViewInsertedEventArgs) Handles DetailsView1.ItemInserted
        BindData()
    End Sub
    
    Private Sub BindData()
        Using myEntities As New AlumniTblEntities
            Dim allProvinces = From province In myEntities.ProvinceTbls
                               Order By province.Province
                               Select New With {province.Province}

            ProvinceGrid.DataSource = allProvinces
            ProvinceGrid.DataBind()
            ProvinceGrid.HeaderRow.Cells(0).Text = "Provinces"

            ProvinceDdl.DataSource = allProvinces
            ProvinceDdl.DataValueField = "Province"
            ProvinceDdl.DataTextField = "Province"
            ProvinceDdl.DataBind()
        End Using
    End Sub

Much cleaner, if you ask me....

Imar

rmanapul · August 30th, 2012, 05:09 AM

is BindData() a function created by you?

Imar · August 30th, 2012, 05:23 AM

Yes, don't you see it in the code?

Imar

rmanapul · August 30th, 2012, 05:25 AM

sorry i dont know how to do functions in visual basic only in c/c++ so i have no idea on how to do it nor recognize it.

rmanapul · August 30th, 2012, 05:26 AM

and thanks for the new knowledge :)

Imar · August 30th, 2012, 07:51 AM

Quote:

i dont know how to do functions in visual basic

I would try to master that before you go the "all code route". Chapter 5 shows how to create functions and sub routines.

Cheers,

Imar

rmanapul · August 30th, 2012, 07:40 PM

thanks. im going to study that XD

rmanapul · August 30th, 2012, 08:36 PM

is it possible to do a file for a class then call it on another file by importing it?

Imar · August 31st, 2012, 02:25 AM

I have no idea what you're asking.

Also, please create a new thread for a new topic, in an appropriate forum. This question doesn't seem to be related to ItemInserted, nor to my book directly. So, a new post in the General ASP.NET 4 category is probably the right thing to do.

Cheers,

Imar