I've tried debugging and even simply retyping this code repeatedly but nothing seems to work. The rest of the page works but the thumbsup image just does not show up.

here's the code:

function generate_ratings($review_rating) {
    $movie_rating = '';
    for($i=0; $i<review_rating; $i++) {
        $movie_rating .= "<img src=\"thumbsup.gif\">";
    }
    return $movie_rating;
}

and this is where it's used:

while($review_row = mysql_fetch_array($review_result)) {
    $review_flag=1;
    $review_title[]=$review_row['review_name'];
    $reviewer_name[]=ucwords($review_row['review_reviewer_name']);
    $review[]=$review_row['review_comment'];
    $review_date[]=$review_row['review_date'];
    $review_rating[]=generate_ratings($review_row['review_rating']);
}


can anybody tell me what I'm missing? thanks!

Hey Angelina,

Is the image actually there? maybe add an alt tag to your <img> tag so that will show up if the path to the image is broken.

Next thing is does the database have some numbers in the review_rating field - looks to me like the function only inserts the image tag if the review_rating field is >0.

You could as a debugging thing have your function return "!" . $movie_rating. If you can see the exclamation mark then its definitely getting called.

Let us know if thats any help.

cheers,

--
Don't Stand on your head - you'll get footprints in your hair
                                           http://charlieharvey.org.uk
                                              http://charlieharvey.com