Chapter 4

soopahNerd · May 13th, 2011, 01:46 AM

Hey all!

Got a quick question and a sneeky neenjuh feeling that I already have the answer.

For the excercise:

Quote:

2. Write an application that includes the logic from Exercise 1, obtains two numbers from the user, and displays them, but rejects any input where both numbers are greater than 10 and asks for two new numbers.

Now, I did this. But when I compared my code to the Appendix code - I was all

.... yea, I thunk I didded it wrong... Funny part? My code works.

So, answering my own question, there are different ways to code - just some is more efficient?

Their Code (example 2):

Code:

bool numbersOK = false;
double var1, var2;
var1 = 0;
var2 = 0;
while (!numbersOK)
{
Console.WriteLine("Give me a number:");
var1 = Convert.ToDouble(Console.ReadLine());
Console.WriteLine("Give me another number:");
var2 = Convert.ToDouble(Console.ReadLine());
if ((var1 > 10) && (var2 > 10))
{
Console.WriteLine("Only one number may be greater than 10.");
}
else
{
numbersOK = true;
}
}
Console.WriteLine("You entered {0} and {1}.", var1, var2);

My Code:

Code:

double firstNum, secNum;
            Console.WriteLine("This program decides which one of 2 numbers is greater than 10.");
            Console.WriteLine();
            Console.WriteLine("What is your first number?");
            firstNum = Convert.ToDouble(Console.ReadLine()); //defines firstNum
            Console.WriteLine("What is your second number?");
            secNum = Convert.ToDouble(Console.ReadLine()); //defines secNum
            if ((firstNum > 10) && (secNum > 10))  //evaluates both numbers to be greater than
            {
                Console.WriteLine();
                Console.WriteLine("Both of your numbers are greater than 10.  Please try again.");
            }
            else if ((firstNum > 10) && (secNum < 10))  //evaluates firstNum to be greater
            {
                Console.WriteLine();
                Console.WriteLine("Your first number {0} is greater than 10 and your second number {1} is less than 10.", firstNum, secNum);
            }
            else if ((firstNum < 10) && (secNum > 10))  // evaluates secNum to be greater
            {
                Console.WriteLine();
                Console.WriteLine("Your first number {0} is less than 10 and your second number {1} is greater.", firstNum, secNum);
            }
            else  // just in case both numbers are less than 10
            {
                Console.WriteLine("Both of your numbers are less than 10!");
            }
            Console.WriteLine();
            Console.WriteLine();
            Console.WriteLine("Press any key to quit");
            Console.ReadKey();

Obviously I could've used bool and some other techniques now seeing their code. I guess the shortcuts come with time? Or, did I miss an important lesson while taking notes?

cobberas63 · May 23rd, 2011, 07:11 AM

soopahNerd

There are always more than one way to write code that will perform a task. Efficiency/brevity comes with looking at how more experienced coders achieve the same sort of outcome and using their techniques in your code.

In general, if you find yourself using a bunch of sequential "if else" statements you should be using a loop and/or a switch statement instead.

From a functional viewpoint, the main difference I see between your code and the text book code is that yours will terminate after each execution whereas the text book one keeps looping until the user quits. Nothing wrong with termination if that's what you want to do at that point.

C/

soopahNerd · May 23rd, 2011, 10:13 AM

I mean, don't get me wrong and I'm appreciative you responded. But I guess the short answer is "Experience"? I mean, all I know about C# was thru Chapter 4 when I wrote that.

My code may not have been ideal, and sure I coulda copied or downloaded the answer....but for a guy to sit down and write his own code from scratch without help - and it function?

Yea, using the loops and whatnot comes from "Experience".

Even Super Man had to learn how to fly :)