chapter 3 question

adamshire · July 27th, 2010, 10:40 AM

on page 89-90 in the function checkComments...

Code:

if (aData[0] != iLastCommentId) {                   
                    
                    iLastCommentId = aData[0];
                    
                    if (iLastCommentId != -1) {                        
                        showNotification(aData[1], aData[2]);
                    }
                    
                }

Shouldn't

Code:

iLastCommentId = aData[0];

come after

Code:

 if (iLastCommentId != -1) {                        
                        showNotification(aData[1], aData[2]);
                    }

otherwise if there is already a comment when you get to the page, it will display, even if it was posted a year ago. If you make the change I'm suggesting, you would only see comments that were posted since you loaded the page. right?

nzakas · July 29th, 2010, 06:09 PM

Please keep in mind that this is just an example. :)

You're correct in that you'll get the last added comment. Whether you want that or not is, of course, dependent on the behavior you're after. It would actually be better to send a timestamp and only return comments after the page was loaded.