Chapter 7 Earthquake 2, Earthquake.java, error onActivityResult

dbomberg · July 28th, 2010, 11:11 PM

I am pretty sure there is an error in the file Earthquake.java
When the user sets a preference and thus the requestCode== SHOW_PREFERENCES , the result of the context menu will not send the desired Activity.RESULT_OK value.

Here is my fix. Any feedback is appreciated.
//BEGINNING OF PROPOSED FIX

Code:

 
    @Override
    public void onActivityResult(int requestCode, int resultCode, Intent data) {
//REMOVED super.onActivityResult(requestCode, resultCode, data);

      if (requestCode == SHOW_PREFERENCES)
//REMOVED if (resultCode == Activity.RESULT_OK) 

    	  { 
          updateFromPreferences();
          refreshEarthquakes();
           } 
      
//ADDED:
      else{
    	  super.onActivityResult(requestCode, resultCode, data);
      }
//END OF ADDED CODE
    }

//END OF THIS POST

Herwig De Smet · November 30th, 2012, 05:34 AM

Hi,
Thanx for your workaround. Can you give the code for the refreshEarthquakes(); method ? Or is this part correct in the book ?
Herwig

Herwig De Smet · November 30th, 2012, 05:52 AM

Hi,

Here is the code that works, and replaces the code on page 231

Code:

public void onActivityResult(int requestCode, int resultCode, Intent data) 
	{
		if (requestCode == SHOW_PREFERENCES)
		{ 
			updateFromPreferences();				 
	        Thread thread = new Thread(new Runnable()
	        {
	        	public void run()
	        	{
	        		FragmentManager fragmentManager = getFragmentManager();
	    	        EarthquakeListFragment earthquakeList = 
	    	          (EarthquakeListFragment)fragmentManager.findFragmentById(R.id.EarthquakeListFragment);
	        		earthquakeList.refreshEarthquakes();
	        	}
	        });
	        thread.start();
		} 
		else
		{
			super.onActivityResult(requestCode, resultCode, data);
		}
    }

Regards,
Herwig