Did you find a mistake?

nzakas · June 20th, 2005, 09:58 AM

Right again, Alexei, I'll submit it to Wrox.

Thanks!

Nicholas C. Zakas
Author, Professional JavaScript for Web Developers (ISBN 0764579088)
http://www.nczonline.net/

AGS · June 20th, 2005, 02:13 PM

Page 320, next to last paragraph

Quote:

quote:As you can see, oRange1âs startContainer, endContainer, and commonAncestorContainer are equal
to the <body/> element because the <p/> element is wholly contained within it. Also, startOffset is
equal to 0, because the <p/> element is the first child of <p/>, and endOffset is equal to 1, meaning that
the range is over before the second child node (which is index 1).

<p/> element is the first child of <body/>?

Best regards,
Alexei

AGS · June 23rd, 2005, 10:48 AM

Page 171, next to last code block

Code:

var oPs = document.getElementsByTagname(âpâ);
var oImgsInP = oPs[0].getElementsByTagName(âimgâ);

Typo (getElementsByTagName)

Best regards,
Alexei

AGS · June 24th, 2005, 04:14 AM

Page 327, last code block
Actually I had some hesitations concerning this topic but still...

Code:

var oP1 = document.getElementById(âp1â);
var oP2 = document.getElementById(âp2â);
var oRange = document.createRange();
oRange.setStartAfter(oP1);
oRange.setStartBefore(oP2);
alert(oRange.collapsed); //outputs âtrueâ

Quote:

quote:In this case, the created range is collapsed because there is nothing between the end of p1 and the beginning
of p2.

I would say that in this case the created range is collapsed because we didn't set the end of the range. May be selected line should be
oRange.setEndBefore(oP2); or may be I missed the point.
And another reason: according to my experiments :) if you try original code and there are indeed other nodes between p1 and p2 you'll get

Quote:

quote:Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMRange.setStartBefore]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: http://localhost/ranges.html :: compareRange :: line 16" data: no]

Best regards,
Alexei

nzakas · June 27th, 2005, 09:57 AM

Alexei, you're right on both counts. I suspect the incorrect capitalization was due to Word's "autocorrect" features. The range issue is undoubtedly a copy-paste oversight.

Thanks,
Nicholas

Nicholas C. Zakas
Author, Professional JavaScript for Web Developers (ISBN 0764579088)
http://www.nczonline.net/

PC · June 27th, 2005, 10:49 AM

Hi!

Some possible errors or missprint.

Page 45.

In first example we have a variable bTrue, but in paragraph following the example, last sentence we find "so that a is set to false", maybe bTrue? (maybe the sentence will be changed...).

Page 46.

" ...the variable c is undefined." bUnknown?

Page 52

Conditional operator last sentence "...iNum2 is less than..." Maybe great than?

Page 67

Last paragraph "As discussed briefly in Chapter 1, ..." Maybe Chapter 2?

Page 69

First paragraph. "In Chapter 1..." Chapter 2?

Page 78

In using UTC(), in paragraphs we find 2004, but in examples 2003?
I've lost something how use UTC()?

Page 84

Second table LOG10E Description "The base 1 logarithm of E". Isn't base 10?

I have a question on using return in function, but I'll send as new topic. It's a stupid question but I'd like understand more...

Bye.

Paolo

nzakas · June 27th, 2005, 11:27 AM

Paolo,

You are right on all counts, these are all mistakes and need to be fixed. Thanks so much for point this out to me. If you find any other mistakes, don't hesitate to post them.

Thanks,
Nicholas

Nicholas C. Zakas
Author, Professional JavaScript for Web Developers (ISBN 0764579088)
http://www.nczonline.net/

AGS · July 8th, 2005, 02:21 AM

May be it doesn't fit this topic but I am more comfortable to post it here :).
Chapter 11, page 346.
(CodeExamples formutil.js -> FormUtil.tabForward)

Code:

    for (var i=0; i < oForm.elements.length; i++) {
        if (oForm.elements[i] == oTextbox) {
             for(var j=i+1; j < oForm.elements.length; j++) {
                 if (oForm.elements[j].type != "hidden") {
                     oForm.elements[j].focus();

I've tried to use this function in current project and stumbled upon following issue:
While "tabforwarding" through controls I got an error "Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus." The reason was that next control was disabled (I think itâs quite common case). Firefox unlike IE doesnât raise an error but stops on this control anyway. So may be it would be appropriate to add this condition:

Code:

if (oForm.elements[j].type != "hidden" && !oForm.elements[j].disabled)

After further experiments I've found another peculiarity: I think there must be preconditions concerning some keys (at least "Shift"). It is quite difficult to select text of "full" textbox because focus always tries to escape to next control :).
And, yes, I am aware that examples in the book were not intended to be of production quality. So notes above are just thoughts about some improvements of this particular method and again I probably should post it in different topic. But what's done can't be undone

.

Best regards,
Alexei

nzakas · July 9th, 2005, 07:50 PM

Very interesting find. I had never tried it with disabled controls, that's a good catch! Your code update is probably the best approach.

Nicholas C. Zakas
Author, Professional JavaScript for Web Developers (ISBN 0764579088)
http://www.nczonline.net/

AGS · September 13th, 2005, 01:12 AM

Page 273
Misprint: duplicate property name pageX instead of pageY.
Best regards,
Alexei