trim function on page 206

jackhsu · December 19th, 2006, 02:03 AM

Hi,
On page 206, you provide a trim function to trim white space,

Code:

String.prototype.trim = function () {
var reExtraSpace = /^\s+(.*?)\s+$/;
return this.replace(reExtraSpace, "$1");
};
var sTest = "  this is a test  ";
alert("[" + sTest + "]"); //outputs Â¡Â° [ this is a test ] Â¡Â°
alert("[" + sTest.trim() + "]"); //outputs Â¡Â° [this is a test]Â¡Â±

But if the being of string to be trimmed has no white space, like "this is a test ", the method can't trim white space in the end, vice versa. So how about to change reExtraSpace to /^\s*(.*?)\s*$/? so that it can do the real trim work? I don't know if it's right. It's just my advice.

nzakas · December 19th, 2006, 01:46 PM

This has already been reported as an issue. Please refer to the errata page for more information: http://www.wrox.com/WileyCDA/WroxTit...ew_errata.html

Nicholas C. Zakas
Author, Professional JavaScript for Web Developers (ISBN 0764579088)
http://www.nczonline.net/