PropertyObject Ch. 3

nativerun · July 20th, 2010, 08:57 PM

Hi,

I am looking at the code from the PropertyObject class in chapter 3.
There is just one thing I can't figure out.

On top of page 57 there is this piece of code:

Code:

if($this->propertyTable[$propertyName] != $value && 
                !in_array($propertyName, $this->changedProperties)) {
                    $this->changedProperties[] = $propertyName;
            }

I don't understand why we are testing the $value against $this->propertyTable[$propertyName]

I would think $this->propertyTable[$propertyName] will match a database table name and never match $value.

It would be understandable for me if $value would be checked agains $this->data[$this->propertyTable[$propertyName]]

Can someone please tell me what I am missing?

Thanks

nativerun · July 22nd, 2010, 06:55 AM

Ok, I have been checking the script by running it and see when the $changedProperties array get's a value assigned. Yes, I should have done that that before I posted the previous comment, sorry for that ;).

It indeed looks that what a stated is correct and this is an error in the code.

this piece of code on page 57:

Code:

if($this->propertyTable[$propertyName] != $value && 
                !in_array($propertyName, $this->changedProperties)) {
                    $this->changedProperties[] = $propertyName;
            }

should be changed to:

Code:

if($this->date[$this->data[propertyTable[$propertyName]] != $value && 
                !in_array($propertyName, $this->changedProperties)) {
                    $this->changedProperties[] = $propertyName;
            }

If you don't change this: the if statement will always be true (because "$this->propertyTable[$propertyName] != $value" will never match) and then the $changedProperties array will always be filled.

Cheers