Post Products plugin generates error...

mb2i · July 22nd, 2010, 05:20 PM

I downloaded the sample code for the Post Products plugin, posted it to my WordPress test server, activated it, and when I try to preview or view the page, I get the following warnings/errors:

Code:

Warning: Missing argument 2 for pp_save_meta_box() in /public_html/wordpress/test/wp-content/plugins/post-products/post-products.php  on line 136

Notice: Undefined variable: post in /public_html/wordpress/test/wp-content/plugins/post-products/post-products.php on line 138

Notice: Trying to get property of non-object in /public_html/wordpress/test/wp-content/plugins/post-products/post-products.php on line 138

Line 136 is:

Code:

function pp_save_meta_box($post_id,$post) {

Line 138 is:

Code:

	if($post->post_type == 'revision') { return; }

I assume it is having trouble finding the $post variable/value but other than a global $post being declared at the top of the file, I can't see where this is being set... it should be passed in via the function call and since the plugin doens't call the function, I'm not sure where the parameters are being set.

What am I missing?

williamsba · July 23rd, 2010, 10:55 AM

Hey mb2i, nice catch! The issue stems when creating a new post. Since it is a new post the global $post variable is empty, thus the errors. You can fix this issue by updating the pp_save_meta_box function to the below code:

PHP Code:


			
function pp_save_meta_box($post_id) {

    global $post;

    

    // if post is a revision skip saving our meta box data

    if( isset( $post) && $post->post_type == 'revision') { return; }

    

    // process form data if $_POST is set

    if(isset($_POST['pp_sku']) && $_POST['pp_sku'] != '') {



        // save the meta box data as post meta using the post ID as a unique prefix

        update_post_meta($post_id,'pp_sku', esc_attr($_POST['pp_sku']));

        update_post_meta($post_id,'pp_price', esc_attr($_POST['pp_price']));

        update_post_meta($post_id,'pp_weight', esc_attr($_POST['pp_weight']));

        update_post_meta($post_id,'pp_color', esc_attr($_POST['pp_color']));

        update_post_meta($post_id,'pp_inventory',esc_attr($_POST['pp_inventory']));



    }

}

Notice I removed $post as a function parameter and instead bring in the global $post value. I also check if the $post variable is set before checking its value. I'll update the downloadable code as well.

Thanks again!