ch06 source code bug

rdfield · June 10th, 2010, 11:10 AM

In the jid_to_id function in chapter 6 there is a line:

.replace(".","-");

which only creates a usable id for servers with 0 or 1 full stops in the name. For a more general approach it should be

.replace(/\./g,"-");

I have multiple djabberd vhosts running and they all have 2 or 3 full stops in the name; it took me a while to figure out why all of my contacts were always marked offline.

metajack · June 10th, 2010, 05:10 PM

Thanks for the tip. Another reader caught this as well, and this (and probably a few other minor fixes) are available in the GitHub repo at http://github.com/metajack/profxmpp

frozeng · December 29th, 2011, 05:52 PM

Came here to point out this problem – my fault for not checking carefully through all the threads first!

It would be better if the wrox ‘dowload code’ link went to the GIT repo as I just assumed it must be the most recent from the official site.

The issue makes the example unusable when your xmpp server hostname is an IP address. As '.' is an illegal attribute character it adds a new tab each time on_message is called as $('#chat-' + jid_id).length always resolves to 0.

As a slight improvement you could use:

Code:

.replace(/[.@]/g, "-") 
to replace all the characters with one call to replace

or safer:
.replace(/[^\w]/g, "-")
to protect against usernames with illegal attribute chars in like tes^[email protected]