Lesson 9 Try It error

MinusZero · October 24th, 2012, 10:11 PM

I encountered a problem while playing with the program.

The buttons all work and open the forms as they should, however, when i close a form I opened and then click to open it again, i get an error.

I checked the Try It from Lesson 9 downloaded from the Wrox site and it has the error too.

Code:

 public Form1()
        {
            InitializeComponent();
        }

        //the remote forms
        GettingThereForm theGettingThereForm;
        GettingAroundForm theGettingAroundForm;
        LodgingForm theLodgingForm;
        FunStuffForm theFunStuffForm;

        private void Form1_Load(object sender, EventArgs e)
        {
            //initialise the form variables but dont display them

            theGettingThereForm = new GettingThereForm();
            theGettingAroundForm = new GettingAroundForm();
            theLodgingForm = new LodgingForm();
            theFunStuffForm = new FunStuffForm();

        }
        
        private void btnGettingThere_Click(object sender, EventArgs e)
        {
            //On button Click, open the form

            theGettingThereForm.Show();

        }

I cant post an image of the error, but it said:

ObjectDisposedException was Unhandled
Cannot access a disposed object
Object name: GettingThereForm

Troubleshooting Tip:
Make sure you have not release a resource before attempting to use it.

What does this mean?? Is it caused by the forms being initialised outside the click handler?

Perhaps this is something that will be covered in later chapters, but I thought i should let you know about the error in case someone else wonders what is going on.

Rod Stephens · October 25th, 2012, 04:06 PM

I'm pretty sure this is fixed in the next lesson. (Let me know if it isn't. I don't have a copy of the book handy so I can't check right now.)

The problem is that if you click the X button on the form's upper right corner, the form is destroyed. Later when you try to display it again, it is gone.

This is related to creating the form outside of the Click event handler. The program only creates one instance of the form and tries to reuse it. That will be useful later but for now it gives you this problem.

The solution (which I hope is coming up soon) is to hide the form instead of destroying it. Then when you need it again you can redisplay it. That saves a little time but more importantly lets the form retain whatever values it had in its controls when it was hidden so when it redisplays it shows the user the previous choices.

MinusZero · October 25th, 2012, 08:17 PM

Thanks, I figured it was something to do with being initialised outside the click handler.

Starting Lesson 11 today, great book.

Rod Stephens · October 25th, 2012, 10:23 PM

Quote:

Starting Lesson 11 today, great book.

Thanks! Post a review when you have a chance.

And keep posting when you get stuck!