Checking if a text box is empty

MinusZero · October 29th, 2012, 08:26 PM

Hi,

I want to be able to check if a text box is empty, show a message if it is, otherwise it should continue to the else code.

When i run the program and try to convert when nothing is in the text box, it skips the message and goes straight to an error "Input string was not in a correct format."

I have noted where the program stops. I figure its because the empty text box isnt a double. It seems to disregard the empty textbox message. I hope i am not in over my head here.

Code:

private void btnLengthConvert_Click(object sender, EventArgs e)
        {
          //check if textbox is empty  
          if (tbxLengthToConvert == null)
            {
                MessageBox.Show("test");
            }
            else

            //CENTIMETRES
            //check if the centimetre radio button is checked and then run the math
            if (rbCM.Checked == true)
            {
                double length = double.Parse(tbxLengthToConvert.Text); ERROR
                double mm = length * 10;
                double cm = length * 1;
                double mt = length * 0.01;
                double km = length * 0.00001;
                double inches = length * 2.54;
                double feet = length * 0.032808399;

                tbxLenMm.Text = mm.ToString();
                tbxLenCm.Text = cm.ToString();
                tbxLenMetres.Text = mt.ToString();
                tbxLenKm.Text = km.ToString();
                tbxLenIn.Text = inches.ToString();
                tbxLenFt.Text = feet.ToString();

            }

Rod Stephens · October 30th, 2012, 10:15 AM

Quote:

//check if textbox is empty
if (tbxLengthToConvert == null)

What this is really doing is comparing the TextBox itself to null. The TextBox exists so it isn't null and this will never be true.

Instead you need to compare the Text inside the TextBox. And don't compare it to null because blank isn't the same as null. For example, try:

Code:

if (tbxLengthToConvert.Text == "")

MinusZero · October 30th, 2012, 06:36 PM

It works, thanks so much. I did try == "" but i didnt have .text before that to associate the text box with the text inside it. Trial and error is a great learning tool. I wont forget that again

Rod Stephens · October 30th, 2012, 09:34 PM

Trial and error is a great learning tool only if it's painful enough!

MinusZero · October 31st, 2012, 11:47 PM

so true. All that pain and frustration is worth it in the end

harry282 · November 19th, 2015, 09:10 PM

Hi everyone
now i'm using VS 2010 and i use " if" but it not working correctly

My code :

Code:

if (input == "a\r\n")
                {
                    
                    RFID.Text += (" Name       ------    \r\n ");
                    RFID.SelectionStart = RFID.Text.Length;
                    RFID.ScrollToCaret();
                    RFID.Refresh();


                   
                 }

input is data receive from serial port
RFID.text display only one time
i don't know why
please help me
thankyou so much

Rod Stephens · November 20th, 2015, 05:07 AM

I know the parentheses shown in red below shouldn't be there. Is anything else going wrong with it?

Code:

if (input == "a\r\n")
{
    RFID.Text += (" Name       ------    \r\n ");
    RFID.SelectionStart = RFID.Text.Length;
    RFID.ScrollToCaret();
    RFID.Refresh();
}

harry282 · November 20th, 2015, 11:53 AM

Code:

if (input == "a\r\n")
                {
                    
                    RFID.Text += " Name       ------    \r\n ";
                    RFID.SelectionStart = RFID.Text.Length;
                    RFID.ScrollToCaret();
                    RFID.Refresh();


                   
                 }

thanks Rod Stephens
I'm trying but it display only one time again
i can't understand
:(

Rod Stephens · November 20th, 2015, 12:27 PM

Well that code doesn't have any sort of looping code in it so it would only run once.

Is the code inside an event handler or something? If so, then it may be a problem with the RFID reader or library or something, but I doubt it's the C# code.

harry282 · November 20th, 2015, 07:16 PM

what should i do . hic