I am writing code to convert a negative binary number to its positive counterpart. The code below doesn't do the conversion properley. Can anyone please help??

#define SIZE 8
void Converter(int binary[])
{
int num[SIZE];

for(count = SIZE - 1; count >= 0; cout--)
{
  if(binary[0] = '1'); // is negative
   sum[count] = 0; // this making everything to zero
} // end for
}



George N. Bilios

__________________
gbilios

I don't know if I can help you with your original problem, but I see some potensial problems in you code:

  Where do you use the num array?
The for-loop will go for ever, since count is not decremented (spelling error most likely).
Where is sum decleared?

Gert

I cant get the code to convert a negative binary number to its positive equivalent, which should add 1 and then convert to decimal. The main issue hgere is that I want the code to be able to turn the zeros into ones and the ones into zeros, egs, 10001100(negative) is converted to 01110011(positive)

#define SIZE 8

int toDecimal(int binary[])
{
int num[SIZE];
int decimal = 0;
int weight = 1;
int num;
int count;
for (count = SIZE -1;count >= 0; count--)
{
  if(binary[0] == '0') // is positive, convert to decimal
  {
         // num = binary % 10;
         num = binary[count];
         decimal = decimal + num * weight ;
         // binary = bianry / 10;
         weight = weight * 2;
   }
   else if (binary[0] == '1')
   {
     // is negative and must be converted to positive
     // equivalent, add 1, and then convert to decimal.
     //....
} // end for
return decimal;
} // end function



George N. Bilios

Uh, why not just xor with all ones? Why use an array of integers at all? That's an incredible waste of space -- to use an entire integer to contain a 1 or 0.

Also, why are you making comparisons to characters? '1' and '0' are characters. This would make sense if your int array, "binary", is actually an array of characters, but that's not how it's declared.

Next issue: Why is your function called "toDecimal" if what you're really doing is taking the bit inverse? It's misleading.

And what the heck does your "weight" variable have to do with anything? Multiplying by two is the same as shifting a binary number to the left once. Why not use a bit shifting operation instead of multiplication?

Why not just multiply your running sum by 2 each iteration, instead of figuring out just one bit, multiplying that by the appropriate power of 2, then adding it to the running sum?


Let me rephrase the above using code:

int num = 0;
for (count = 0; count < SIZE; ++count)
{
    num *= 2; // shift left.
    num += (binary[count] == '1')? 0 : 1
}

Isn't that easier than dealing with three different variables?


Take care,

Nik
http://www.bigaction.org/

the first thing thats suppose to happen in toDecimal is convert a binary number to positive, only if the binary number is a positive. if the binary number was a negative it would convert it to a positive, add 1 (two's complement), then convert to decimal(result).

The original function toDecimal converted a binary number to decimal.
all i did was add code to it so i could enter a two's complement number
and deal with it. obviously my code is wrong.

thanks for helping me.





George N. Bilios

one point though, in two's complement, a negative binary number is first converted to positive, and then a 1 is added to the rightmost bit. The code you rephrased does not add a one to the rightmost bit of the result:

int count;
int num = 0;
for (count = 0; count < SIZE; ++count)
{
    num *= 2; // shift left.
    num += (binary[count] == '1')? 0 : 1;
} // end for



George N. Bilios

after five months ;)
yes you are right after above code,write below code
--------------------------------------------
Mehdi.:)