simple error

jack_3 · November 15th, 2005, 09:03 AM

Hi
Here this is my program to access xml file , and i am getting an error "not all code return a value".

Anybody plz hlp ....

namespace XMLMIntro
{
class Exercise
{
public int ShowContinents(string xmlFileName, string Name)
{
XmlDocument xmlDocument = new XmlDocument();
xmlDocument.Load(xmlFileName);

XmlElement elem = xmlDocument.DocumentElement;
XmlNode Node = elem.FirstChild;
XmlNodeList lstadd = elem.GetElementsByTagName("add");

if (Node.HasChildNodes)
{
for (int i = 0; i < lstadd.Count; i++)
{

if (addList[i].Attributes["name"].InnerText == Name)
{
int returnValue = (System.Convert.ToInt32(addAttributes["value"].InnerText));
return returnValue;
}
}
}
}
}
}

jacob · November 15th, 2005, 09:08 AM

Read the error message. If you evaluate you prorgam you will notice that you only return a value when Node.HasChildNodes and addList[i].Attributes["name"].InnerText == Name. What integer value will be returned if this is not the case?

Jacob.

jacob · November 15th, 2005, 09:15 AM

BTW... I believe that your error message is something like not all paths return a value, and therefore a Google search would render the following...

http://www.google.dk/search?hl=da&q=...%22+.net&meta=

Hope it helps, Jacob ;)

jack_3 · November 15th, 2005, 10:21 AM

Hi Jacob,
Thanq for the reply. But what value I have to return
eg:return 1;
is correct?

jacob · November 15th, 2005, 10:56 AM

It depends heavily on the flow of the program you are designing. I am not too sure what you are trying to accomplish, but if you specify in the method signature that you want to return an integer, then you have to return an integer; i.e. no matter what path is chosen.

E.g. if you know that your method always returns a possitive integer when the method returns as you would like, then you could return -1 for the case where if fails to return what you would like.

Code:

public int ShowContinents(string xmlFileName, string Name)
{
    ...
    if(Node.HasChildNodes)
    {
        for(int i = 0; i < lstadd.Count; i++)
        {
            if(addList[i].Attributes["name"].InnerText == Name)
            {
                ...
                return returnValue; // returnValue always possitive.
            }
        }
    }
    return -1;
}

When you call your method ShowContinents you can ask if it is -1 or not. This is just an example, however, remember to return from all paths.

HtH, Jacob.

jack_3 · November 16th, 2005, 08:05 AM

Thanks Jacob ,
It Worked!
cheers
Jack