Not all code returns a value

Doom · February 11th, 2008, 03:04 PM

Hi there i have written this application.

Code:

using System;

namespace StevenHaynesCSharp.Maths
{
    class AcuteObtuse
    {
        public float AcuteObtuseTester(int x)
        {
            if (x <= 90)
            {
                Console.WriteLine("Your Angle Is Acute");
            }
            else if ((x > 90) && (x <= 180))
            {
                Console.WriteLine("Your Angle Is Obtuse");
            }
            else
            {
                Console.WriteLine("Invalid");
            }
        }
    }

    class MainEntryPoint
    {
        public static int Main()
        {
            AcuteObtuse acuteobtuse = new AcuteObtuse();

            Console.WriteLine(acuteobtuse.AcuteObtuseTester(66));
            return 0;
        }
    }
}

This the error is get when trying to compile it.

Code:

Error    1    'StevenHaynesCSharp.Maths.AcuteObtuse.AcuteObtuseTester(int)': not all code paths return a value    C:\Users\Administrator\AppData\Local\Temporary Projects\Project1\CodeFile1.cs    7    22    Project1

Can anyone point me in the correct direction for fixing this.

Thanks
Doom

Imar · February 11th, 2008, 03:09 PM

Take a look at the function header:

public float AcuteObtuseTester(int x)

You're saying it's returning a float. Yet, you never return a value from it. So, change the method so it returns a valid float value (or uses a different mechanism to successfully end the method (like throwing an exception), or change the method from float to void which means you don't need to return anything:

public void AcuteObtuseTester(int x)

Finally, it's odd to have a method that outputs to the console being called from another call to Consoles.WriteLine...

Cheers,

Imar
---------------------------------------
Imar Spaanjaars
http://Imar.Spaanjaars.Com
Everyone is unique, except for me.
Author of ASP.NET 2.0 Instant Results and Beginning Dreamweaver MX / MX 2004
Want to be my colleague? Then check out this post.

dparsons · February 11th, 2008, 03:10 PM

O.o

I am going to assume that you are a Novice in a programming. The compiler is telling you everything you need to know: all of the code paths in your method AcuteObtuseTester do not return values.

What is confusing is that you have defined a return type of float but you don't return anything in any code paths? Plainly put, I am not sure what your intent is here.

Anyway, you can change your code like this:

        public string AcuteObtuseTester(int x)
        {
            if (x <= 90)
            {
                return "Your Angle Is Acute";
            }
            else if ((x > 90) && (x <= 180))
            {
                return "Your Angle Is Obtuse";
            }
            else
            {
                return "Invalid";
            }
        }

     public static int Main()
        {
            AcuteObtuse acuteobtuse = new AcuteObtuse();

            Console.WriteLine(acuteobtuse.AcuteObtuseTester(66 ));
            return 0;
        }

hth.

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
================================================== =========
.: Wrox Technical Editor / Author :.
Wrox Books 24 x 7
================================================== =========

dparsons · February 11th, 2008, 03:12 PM

And Imar beat me to it. =P

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
================================================== =========
.: Wrox Technical Editor / Author :.
Wrox Books 24 x 7
================================================== =========

Doom · February 11th, 2008, 03:48 PM

Thankyou for helping me. My code now looks like.

Code:

using System;

namespace StevenHaynesCSharp.Maths
{
    class AcuteObtuse
    {
        public void AcuteObtuseTester(int x)
        {
            if (x <= 90)
            {
                Console.WriteLine("Your Angle Is Acute");
            }
            else if ((x > 90) && (x <= 180))
            {
                Console.WriteLine("Your Angle Is Obtuse");
            }
            else
            {
                Console.WriteLine("Invalid");
            }
        }
    }

    class MainEntryPoint
    {
        public static int Main()
        {
            AcuteObtuse acuteobtuse = new AcuteObtuse();

            acuteobtuse.AcuteObtuseTester(66);
            return 0;
        }
    }
}