Querystrings and Redirects

hcweb · July 29th, 2003, 04:59 PM

Hello all..
I'm trying to retrieve the id from a recordset below and insert it into the querystring for the redirect. Can anyone tell me the correct syntax to accomplish this? Below is some code as an example.

<% Response.Buffer TRUE %>
<%
  Option Explicit
  Dim strConnect
%>


<%
  Dim objRS, objComm, strPrecNo
  strPrecNo = Request.Querystring("precinct")

  If strPrecNo = "False" Then
    Response.Write " Error in file "
  End IF

  Set objComm = Server.CreateObject("ADODB.Command")
  objComm.ActiveConnection = strConnect
  objComm.CommandText = "SELECT id from FILES WHERE tab_precinct_no = '" & strPrecNo & "' "

  objComm.CommandType = adCmdText
  Set objRS = objComm.Execute
  Set objComm = Nothing

  If objRS.EOF Then
    Response.Write "<b>File Not Found</b>"

  Else
    Response.Redirect "file.asp?id=" & objRS("id")
  End IF

  objRS.Close
  Set objRS = Nothing
  'Set objConn = Nothing
%>

Any help would be greatly appreciated!

kosla78 · July 30th, 2003, 01:00 AM

Using your code I would suggest this. The difference is that you wont have a message if no record is returned.Let me know if it suits you :)

Cheers
Kostas

Code:

Dim objRS, strPrecNo
  strPrecNo = Request.Querystring("precinct")
  strSQL="SELECT id from FILES WHERE tab_precinct_no = '" & strPrecNo & "' "


  If strPrecNo = "False" Then
    Response.Write " Error in file "
  End IF
  Set objRs=Server.CreateObject("ADODB.RecordSet")
  objRs.Open strSQL, objConn

  'Do this if there is a record returned
  While Not objRS.EOF and objRs.BOF
    Response.Redirect "file.asp?id=" & objRS("id")
  Wend

  objRS.Close
  Set objRS = Nothing  
  'Set objConn = Nothing

rodmcleay · July 30th, 2003, 01:10 AM

hcweb,
I am not sure if this is a problem with your code or not but I highly recommend not using key words such as "id" for your tables field names.
This includes names such as "date","Length" and any other key words.
I try to avoid key words from VBScript or Javascript as well as SQL for clarity.
FileID would be better.

Rod

======================================
They say, best men are moulded out of faults,
And, for the most, become much more the better
For being a little bad.
======================================

hcweb · July 30th, 2003, 08:50 AM

Thanks for the responses guys! After fooling around with it this morning, it started working. Not sure exactly what changed or why it started working though.

The problem I was having was in the code below:

  Else
    Response.Redirect "file.asp?id=" & objRS("id")
  End IF

For some reason, this would just error out with an internal server error 500. I thought I may have had the syntax wrong in creating the querystring because of the error, but reviewing my code again, it's still the same. Nothing else has changed codewise, so I'm unsure of what exactly has happened.