variable to equal part of string

dparsons · May 16th, 2007, 10:39 AM

Ok, in the select statement I don't see any problems, however this CASE is going to be huge (and it isn't very readable). I suggest you break that email code out into one method such as

Sub sendEmail(state)
Dim sEmail
  Select Case state
    Case "NY"
       sEmail = "[email protected]"
    Case "MS"
       sEmail= "[email protected]"
  End Select

objNewMail.From = sEmail
'Send the email
End

Your above case code becomes:

Select Case sState
    Case "NY"
        sendEmail("NY")
    Case "MS"
        sendEmail("MS")
End Select

Much more readable isn't it? ^^ Also, check to see if your code is ever entering the MS Case by doing a response.write inside of the case. If your text gets wrote to the screen, the problem lies in the email code, not the Case logic.

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
================================================== =========
Technical Editor for: Professional Search Engine Optimization with ASP.NET
http://www.wiley.com/WileyCDA/WileyT...470131470.html
================================================== =========
Why can't Programmers, program??
http://www.codinghorror.com/blog/archives/000781.html
================================================== =========

melkin · May 16th, 2007, 11:03 AM

Thanks again Dparsons! getting there, almost...
I get a compliation error when using SUB:

<%
Dim warehouse, MyArray
warehouse=Request.Form("warehouse")
MyArray = Split(warehouse,",") 'the delimiter is the comma
For I = 0 to UBound(MyArray)
 sState = MyArray(I)
 SELECT CASE sState
 Sub sendEmail(sState)
Dim sEmail
 Select Case sState
 Case "NY"
 sEmail = "[email protected]"
 Case "MS"
 sEmail= "[email protected]"
 End Select

objNewMail.From = sEmail
'Send the email

Set objNewMail = Server.CreateObject("CDONTS.NewMail")

objNewMail.From = sEmail
objNewMail.To = rs("email")

objNewMail.Subject = "An Advance Tabco Order From Your NY Factory!"
objNewMail.BodyFormat = CdoBodyFormatHTML
objNewMail.Body = " <img src='http://www.advancetabco.com/pics/AT_emailLogo.jpg' border=0> **** EXCESS INVENTORY ORDER! **** If you have any questions regarding this order, Please contact Customer Service! COMPANY INFO: Order Date: " & Request.Form("date") & " P.O. Number: " & Request.Form("po") & " " & "Customer Number: " & Request.Form("custcode") & " "& "Company: " & Request.Form("custname") & " " & "Phone: " & Request.Form("phone") & " " & "Address 1: " & Request.Form("add1") & " " & "Address 2: " & Request.Form("add2") & " "& "City: " & Request.Form("city") & " "& "State: " & Request.Form("state") & " "&" Zip Code: " & Request.Form("zip") &" SHIPPING INFO: " & "Address 1: " & Request.Form("shipadd1") & " " & "Address 2: " & Request.Form("shipadd2") & " "& "City: " & Request.Form("shipcity") & " "& "State: " & Request.Form("shipstate") & " "&" Zip Code: " & Request.Form("shipzip") & " "&" Attention: " & Request.Form("attention") &" "& Request.Form("warehouse") &" ORDER INFO: "& " "& Request.Form("model") & " "& "Total Cost: $" & Request.Form("grandtotal") & " "
objNewMail.Send
End
Set objNewMail = Nothing
Select Case sState
 Case "NY"
 sendEmail("NY")
 Case "MS"
 sendEmail("MS")
End Select

 response.write myArray(i) & " "

Next
%>

dparsons · May 16th, 2007, 11:36 AM

Hmm. I am going to make the assumption that you are new to programming period and not just ASP; is that a correct assumption? Also I noticed a problem with my code.

Your code should look like this:
'This should replace the code i have been helping you with since the beining of the post
Select Case sState
 Case "NY"
 sendEmail("NY", rs("email"))
 Case "MS"
 sendEmail("MS", rs("email"))
End Select

'This should exist in the same file as the above code
Sub sendEmail(state, sEmailTo)
Dim sEmail
Select Case state
 Case "NY"
 sEmail = "[email protected]"
 Case "MS"
 sEmail= "[email protected]"
End Select

Set objNewMail = Server.CreateObject("CDONTS.NewMail")

objNewMail.From = sEmail
objNewMail.To = sEmailTo

objNewMail.Subject = "An Advance Tabco Order From Your NY Factory!"
objNewMail.BodyFormat = CdoBodyFormatHTML
objNewMail.Body = " <img src='http://www.advancetabco.com/pics/AT_emailLogo.jpg' border=0> **** EXCESS INVENTORY ORDER! **** If you have any questions regarding this order, Please contact Customer Service! COMPANY INFO: Order Date: " & Request.Form("date") & " P.O. Number: " & Request.Form("po") & " " & "Customer Number: " & Request.Form("custcode") & " "& "Company: " & Request.Form("custname") & " " & "Phone: " & Request.Form("phone") & " " & "Address 1: " & Request.Form("add1") & " " & "Address 2: " & Request.Form("add2") & " "& "City: " & Request.Form("city") & " "& "State: " & Request.Form("state") & " "&" Zip Code: " & Request.Form("zip") &" SHIPPING INFO: " & "Address 1: " & Request.Form("shipadd1") & " " & "Address 2: " & Request.Form("shipadd2") & " "& "City: " & Request.Form("shipcity") & " "& "State: " & Request.Form("shipstate") & " "&" Zip Code: " & Request.Form("shipzip") & " "&" Attention: " & Request.Form("attention") &" "& Request.Form("warehouse") &" ORDER INFO: "& " "& Request.Form("model") & " "& "Total Cost: $" & Request.Form("grandtotal") & " "
objNewMail.Send
Set objNewMail = Nothing
End Sub

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
================================================== =========
Technical Editor for: Professional Search Engine Optimization with ASP.NET
http://www.wiley.com/WileyCDA/WileyT...470131470.html
================================================== =========
Why can't Programmers, program??
http://www.codinghorror.com/blog/archives/000781.html
================================================== =========

melkin · May 16th, 2007, 03:22 PM

Very close now!!

Ok, my code will only take the first state and mail to that address. I need the email to go to ALL the states listed in that dynamic field. If someone orders 2 products that come my different factories, those factories in those steates ned the same email info.

code:
Dim warehouse, MyArray
warehouse=Request.Form("warehouse")
MyArray = Split(warehouse,",") 'the delimiter is the comma
For I = 0 to UBound(MyArray)
 sState = MyArray(I)
Select Case sState
 Case "NY"
 sendEmail "NY", rs("email")
 Case "MS"
 sendEmail "MS", rs("email")
End Select
Next
Sub sendEmail(state, sEmailTo)
Dim sEmail
Select Case state
 Case "NY"
 sEmail = "[email protected]"
 Case "MS"
 sEmail= "[email protected]"
 Case "TX"
 sEmail= "[email protected]"
End Select
response.write myArray(i) & " "

Set objNewMail = Server.CreateObject("CDONTS.NewMail")

objNewMail.From = sEmail
objNewMail.To = sEmail

dparsons · May 16th, 2007, 04:19 PM

hmm. I am not sure I understand. This is very cryptic: I need the email to go to ALL the states listed in that dynamic field.

Please explain.

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
================================================== =========
Technical Editor for: Professional Search Engine Optimization with ASP.NET
http://www.wiley.com/WileyCDA/WileyT...470131470.html
================================================== =========
Why can't Programmers, program??
http://www.codinghorror.com/blog/archives/000781.html
================================================== =========

melkin · May 17th, 2007, 07:51 AM

Here is my full code. Based on the fields showing NY, MS it only outputs whatever the first state is. BUT it will write BOTH states to the page and display BOTH states

<%
Dim warehouse, MyArray
warehouse=Request.Form("warehouse")
MyArray = Split(warehouse,",") 'the delimiter is the comma
For I = 0 to UBound(MyArray)
 sState = MyArray(I)
Select Case sState
 Case "NY"
 sendEmail "NY", rs("email")
 Case "MS"
 sendEmail "MS", rs("email")
End Select
response.write myArray(i) & " "

Next
Sub sendEmail(state, sEmailTo)
Dim sEmail
Select Case state
 Case "NY"
 sEmail = "[email protected]"
 Case "MS"
 sEmail= "[email protected]"
 Case "TX"
 sEmail= "[email protected]"
End Select

Set objNewMail = Server.CreateObject("CDONTS.NewMail")

objNewMail.From = sEmail
objNewMail.To = sEmail

objNewMail.Subject = "An Advance Tabco Order From Your NY Factory!"
objNewMail.BodyFormat = CdoBodyFormatHTML
objNewMail.Body = " <img src='http://www.advancetabco.com/pics/AT_emailLogo.jpg' border=0> **** EXCESS INVENTORY ORDER! **** If you have any questions regarding this order, Please contact Customer Service! COMPANY INFO: Order Date: " & Request.Form("date") & " P.O. Number: " & Request.Form("po") & " " & "Customer Number: " & Request.Form("custcode") & " "& "Company: " & Request.Form("custname") & " " & "Phone: " & Request.Form("phone") & " " & "Address 1: " & Request.Form("add1") & " " & "Address 2: " & Request.Form("add2") & " "& "City: " & Request.Form("city") & " "& "State: " & Request.Form("state") & " "&" Zip Code: " & Request.Form("zip") &" SHIPPING INFO: " & "Address 1: " & Request.Form("shipadd1") & " " & "Address 2: " & Request.Form("shipadd2") & " "& "City: " & Request.Form("shipcity") & " "& "State: " & Request.Form("shipstate") & " "&" Zip Code: " & Request.Form("shipzip") & " "&" Attention: " & Request.Form("attention") &" "& Request.Form("warehouse") &" ORDER INFO: "& " "& Request.Form("model") & " "& "Total Cost: $" & Request.Form("grandtotal") & " "
objNewMail.Send
Set objNewMail = Nothing
End Sub
%>

dparsons · May 17th, 2007, 08:09 AM

Hmm. Case Statements ARE case sensitive so if MS is actually ms it is going to be ignored by the case statement.

So do this:

sState = MyArray(I)
sState = ToUpper(sState)

That will convert your string to all upper case. Also, for the sake of argument, place a Response.Write in your Case for MS and see if it executes.

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
================================================== =========
Technical Editor for: Professional Search Engine Optimization with ASP.NET
http://www.wiley.com/WileyCDA/WileyT...470131470.html
================================================== =========
Why can't Programmers, program??
http://www.codinghorror.com/blog/archives/000781.html
================================================== =========

melkin · May 17th, 2007, 08:13 AM

The states are pulled from a database, then appears in thei fields. Like a shopping cart, showing what the person is purchasing.in which is ALWAYS uppercase. Dont think this is the issue?

dparsons · May 17th, 2007, 08:22 AM

Quote:

quote:Originally posted by dparsons
Also, for the sake of argument, place a Response.Write in your Case for MS and see if it executes.

================================================== =========
Read this if you want to know how to get a correct reply for your question:
http://www.catb.org/~esr/faqs/smart-questions.html
================================================== =========
Technical Editor for: Professional Search Engine Optimization with ASP.NET
http://www.wiley.com/WileyCDA/WileyT...470131470.html
================================================== =========
Why can't Programmers, program??
http://www.codinghorror.com/blog/archives/000781.html
================================================== =========

melkin · May 17th, 2007, 08:25 AM

what was you last post dparsons? I dont see your comments.