i have some problem about my page that writes by asp but update access.
i don't knows its where wrong is/
Please check for me my code.

listcategory.asp

  <%
          set rs=conn.execute("Select * from categories")
          while not rs.eof
         %>
                 <tr>
                   <th scope="row">&nbsp;</th>
                   <th scope="row"><%=rs("categoryname")%></th>
                   <th scope="row">
                   <a href="FormUpdateCategories.asp?Categoryid=<%=rs("C ategoryID")%>">Edit</a></th>
                    </tr>
             <%
             rs.movenext
             wend
             rs.close
%>
formupdatecategory.asp


 <%
   set rs=conn.execute("Select * from categories where CategoryID="+request.QueryString(("CategoryID")))
 %>

and then error is by Browser

Microsoft OLE DB Provider for ODBC Drivers (0x80040E10)
[Microsoft][ODBC Microsoft Access Driver] Too few parameters. Expected 1.
/VINATECH/Adminsite/FormUpdateCategories.asp, line 3

I preserve that CategoryID is some of number data types...

Try in formupdatecategory.asp

set rs=conn.execute("SELECT * FROM categories WHERE CategoryID="+request("CategoryID")+";"

if categoryid is number in other case you must enclose it to aphostrophes like this:

set rs=conn.execute("SELECT * FROM categories WHERE CategoryID='"+request("CategoryID")+"';"

Works it?

Other hints: Check spelling in column names in database;
ensure that value is given thru:

it is much better if you build up the string and after this you call it:
query="SELECT * FROM categories WHERE CategoryID="+request("CategoryID")+";"
set rs=conn.execute(query)

bacause you can write query before executing by the

response.write query

and debug much errors this simple way

If it is not work please post the computed SQL query when the script fails

JVV

Thanks so much to your help
but i have another error when i update database
that error:
formupdateproduct.asp
<form action=CodeAdd.asp?Option=AddProducts&ProductID=<% =request("ProductID")%> method="post" name=form >
</form>


codeupdate.asp

if trim(request("Option"))="UpdateProducts" then
        productid = trim(request.form("productid"))
        '="SELECT * FROM products WHERE productid="+request("productid")+";"
         query="UPDATE products SET productid ='"&productid&"',productname='"&productname&"',pro ductdecription='"&productdescription&"',price='"&p rice&"',equipment ='"&Equipment&"',productorder ='"&productorder&"',productstatus ='"&productstatus&"',productimage ='"&productimage&"',producerid ='"&producerid&"',categoryid ='"&categoryid&"',type ='"&producttype&"',stock ='"&stock&"'WHERE productid ="+request.QueryString("productid")+";"
            set rs=conn.execute(query)
            'response.Write(query)
            Response.Redirect("ListProduct.asp")
            rs.Close
            Set rs=nothing
        end if
and it error:
Microsoft OLE DB Provider for ODBC Drivers (0x80040E10)
[Microsoft][ODBC Microsoft Access Driver] Too few parameters. Expected 1.
/Vinatech/Adminsite/codeupdate.asp, line 61
line 61:
query="UPDATE products SET productid ='"&productid&"',productname='"&productname&"',pro ductdecription='"&productdescription&"',price='"&p rice&"',equipment ='"&Equipment&"',productorder ='"&productorder&"',productstatus ='"&productstatus&"',productimage ='"&productimage&"',producerid ='"&producerid&"',categoryid ='"&categoryid&"',type ='"&producttype&"',stock ='"&stock&"'WHERE productid ="+request.QueryString("productid")+";"

I very fun that you show me to do that
thanks.
i have completed it and it run

You should try to add my validate function (see bellow) and use it for string values. The point - as you propably know - is that the string value you must enclose to apostrophes, but there is two exclusions: the empty string and the string that contains aphostrophe. As empty string you cannot use '' but Null operator and if the string contains apostrophe you must use double apostrophe. This can be done by the validate function. There are some examples:

response.write validate("")
null

response.write validate("hello")
'hello'

response.write validate("it's done")
'it''s done'

so the function

function validate(text)
if text="" then
validate="null"
else
for a=len(text) to 1 step -1
if mid(text,a,1)="'" then
if mid(text,a-1,1)<>"'" then
leva=left(text,a-1)
prava=right(text,len(text)-a+1)
text=leva+"'"+prava
end if
end if
next

validate="'"+text+"'"
end if
end function

maybe you can use replace function but Im not sure that ASP supports it, maybe it is in VB6 only

you must use it only for string and date values, numbers must be without apostophes...

JVV

This post kind of lost me but change:

='"&stock&"'WHERE productid ="+request.QueryString("productid")+";"

To:

='"&stock&"' WHERE productid = " & request.QueryString("productid") & ";"

NOTE - get rid of the + and puut a space before the W in WHERE

An observation - is the field productid a string or an integer? If its an interger remove the single quotes.

Wind is your friend
Matt
www.elitemarquees.com.au

Thanks so much everybody to help me.
Have a good day
Regards
Hoang Phuc