dynamic variable names

Sheraz Khan · January 20th, 2009, 05:27 AM

Hi
I am requesting values from form and saving in variables iFName1,iFName2,iFName3...iFName5

Now because some of the variables would be empty so checking them within an if statement and if the are not empty then save in variable FName (that later on store in the database). Because my variabe names are same apart from the last number there for i am trying to create the variable name on runtime but for some reason rather then saving the variable value i am getting the actual variable name in the variable Fname, ANY IDEA WHAT I AM DOING WRONG HERE?

many thanks

Dim iRName,iREmail,iFName1,iFEmail1,iFName2,iFEmail2,i FName3,iFEmail3,iFName4,iFEmail4,iFName5,iFEmail5, FName, FEmail

'' Retrive form fields
iRName = trim(request.Form("iRName"))
iREmail = trim(request.Form("iREmail"))
iFName1 = trim(request.Form("iFName1"))
iFEmail1 = trim(request.Form("iFEmail1"))
iFName2 = trim(request.Form("iFName2"))
iFEmail2 = trim(request.Form("iFEmail2"))
iFName3 = trim(request.Form("iFName3"))
iFEmail3 = trim(request.Form("iFEmail3"))
iFName4 = trim(request.Form("iFName4"))
iFEmail4 = trim(request.Form("iFEmail4"))
iFName5 = trim(request.Form("iFName5"))
iFEmail5 = trim(request.Form("iFEmail5"))

Dim i

For i=1 to 5
if iFName & i <> "" AND iFEmail & i <> "" then
FName= iFName & i
FEmail=iFEmail & i

response.Write(FName)
response.Write(FEmail)
end if

'VALUES GOES IN DB HERE

next

aspless · January 20th, 2009, 12:12 PM

Sheraz,

I've had a play with the code and added a few array variables..

Try amending the below code (works) to your needs..

Code:

<%
Dim iFName(5),iFEmail(5)
'' Retrive form fields
iRName = "name"
iREmail = "[email protected]"
iFName(1) = "name1"
iFEmail(1) = "[email protected]"
iFName(2) =  "name2"
iFEmail(2) =  "[email protected]"
iFName(3) = "name3"
iFEmail(3) =  "[email protected]"
iFName(4 )= "name4"
iFEmail(4) =  "[email protected]"
iFName(5) = "name5"
iFEmail(5) =  "[email protected]"
 
Dim i
For i=1 to 5
if iFName(i) <> "" and iFEmail(i) <> "" then
response.Write iFName(i) & "." & iFEmail(i) & "<br>"
end if
next
%>

I am sure one of the more senior members can do a neater job but see how you get on.

Cheers

Aspless

Old Pedant · January 20th, 2009, 04:39 PM

I don't get that, at all. You have a comment that says

Quote:

'' Retrive form fields

but then you don't actually retrieve any form fields, at all.

HUH?

Old Pedant · January 20th, 2009, 04:46 PM

ASPLess has the right idea: Use an array.

But you complicated your own life by naming your form fields INCONSISTENTLY. Some of your form field names have a number on the end ("iFName1") and some don't ("ifName").

Okay, we can use your form names, but it would be easier and more consistent if you'd put a number on EVERY ONE of them.

Code:

Dim iRName(5), iREmail(5)
For i = 0 To 5
    If i = 0 Then prefix = "" Else prefix = i 
    iRName(i) = trim(request.Form("iRName" & prefix))
    iREmail(i) = trim(request.Form("iREmail" & prefix))
Next

' and then you can do
For i = 0 To 5
     If iRName(i) <> "" And iREmail(i) <> "" Then
         Response.Write iRName(i) & "::" & iREmail(i) & "<p>" & vbNewLine
     End If
Next