Passing an array from module to form

ftm · March 7th, 2007, 10:18 AM

I have been struggling with a problem passing a small array to be used in a form and I hope that somebody can help me. I cannot get the array into the form.

In the main module code I have an array containing information on a book reference:

Code:

Private Function PresentForm1(ByRef iID() As String, sBookRef() As String) As Boolean
Dim iCounter As Integer
For iCounter = LBound(iID) To UBound(iID)
    Form1.ListBox1.AddItem iID(iCounter)
Next Form1.ListBox1.Selected(0) = True
For iCounter = 0 To 2
MsgBox sBookRef(iCounter) ' This bit works fine
Next iCounter
Form1.Show
End Function

I need to use the sBookRef() array in a form that is called from the function so that a caption on the form changes depending on the item selected in the list box. Something along the lines of:

Code:

Private Sub ListBox1_Click() 
Label1.Caption = sBookRef(ListBox1.ListIndex)
End Sub

When I run the code I get a subscript out of range error.
I added the extra bit of code with the MsgBox to show that there are 3 valid values in the sBookRef() array within the lifetime of the original function. The problem I am having is in passing that array into the form so I can use it there.
I tried listing the array at the top of the module But it didn't seem to work either:

Code:

Public sBookRed() As String

Can anybody please help ?:(

allenm · March 7th, 2007, 03:54 PM

Is the label declaration being called PRIOR to the initialization of the array? That would cause this error.

Also If the code gets called before an item is selected in the listbox, the listbox will return a -1 value and that would also cause this error.

I suggest a slight modification to the line that sets the caption:
If ListBox1.ListIndex < 0 Then Label1.Caption = "<No Selection>" Else Label1.Caption=sBookRef(ListBox1.ListIndex)

It would also be prudent to make sure that ListItem isn't greater than the array.

Hope this helps.

ftm · March 8th, 2007, 07:39 AM

Many thanks for replying. I shall try out your suggestions.