jsp & mysql login code sos

jaymak121 · November 23rd, 2004, 04:59 PM

hi all i was hoping that somebody cud help me with my code for my login page. i am very new to jsp as am currently a student but i know that once somebody has corrected my code i will be able to then pick things up.
ok then basicall i hav created a login page and when client side validation is ok the form data gets sent to a login validatation page. i have pasted the code i have done for the validation page below. currently i can successfully connect to the database and execute an sql qry but it is the if structure when i must compare the user entered details to the database details to see if they match
i wud be grateful for the help here
thanks code is below

--------loginvalidation.jsp-------------
<%@ page contentType="text/html; charset=iso-8859-1" language="java" import='java.sql.*, javax.sql.*,javax.naming.*'%>
<html>
<head>
<title>login validator</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<%
Context ic = new InitialContext();
DataSource ds = (DataSource)ic.lookup("java:comp/env/jdbc/test");

Connection conn = ds.getConnection();

try
{
    String user = request.getParameter("txtusername");
    String password = request.getParameter("txtpassword");
    String dbpass = "";

    Statement stmt = conn.createStatement();
    ResultSet rs = stmt.executeQuery("select password from myusers WHERE username = '" + user + "'");

    while(rs.next())
    {
        dbpass = rs.getString(4);
    }
    if (password.equals(dbpass))
        {

        }
    else
        {

        }
}
finally
{
    conn.close();
}

%>

</body>
</html>

angrycat · November 24th, 2004, 09:29 AM

Your if statement looks ok to me, but I am not sure about the SQL.
You are selecting only 'password', but then trying to dbpass = rs.getString(4);

You could try dbpass = rs.getString("password");

Or if you want all strings/field in the recordset available I would use:

select * from myusers WHERE username

you could then use rs.getString(1); rs.getString(2); ... etc

Also you should try writing the value of dbpass to the screen to check its value is correct:

out.println(dbpass);

Remember Java is case sensitive, so make sure you enter password correctly.

jaymak121 · November 24th, 2004, 04:30 PM

hi thanks for your response
working on mu code last night i had one of those eureka moments and finally cracked it and understood what i was doing
thanks very much for your help

angrycat · November 25th, 2004, 05:44 AM

Thats ok, what are you building??

jaymak121 · November 25th, 2004, 06:50 AM

hi friend
yeah i am new to jsp / mysql but i am trying to build a simple music downloads website. i want to be able to code dynamic webpages. i am using jsp / mysql / and resin as the localhost
thanks