Open a new window from an anchor

jvanscha · August 5th, 2005, 09:13 AM

I'm simply trying to open a new window with a picture when the user clicks on an image from within a JSP page.

Code:

function openNewWin(linkURL) {
window.open(""+linkURL+"", "", "scrollbars, top="+winTop+", left="+winLeft+", height="+winHeight+", width="+winWidth+"");
}

var linkURL = "/TestSite/jsp/showPhoto.jsp"
document.write('<tr><td align="center"><a href="javascript:openNewWin('+ linkURL +');">');

I've tried about 10 different configurations and I can't get any of them to work. Any suggestions?

joefawcett · August 5th, 2005, 11:01 AM

Perhaps you have a popup blocker?
In any case try adding this to see if you call looks valid:

Code:

function openNewWin(linkURL)
{
var sFeatures = "scrollbars, top="+winTop+", left="+winLeft+", height="+winHeight+", width="+winWidth+"";
alert(linkURL + "\n" + sFeatures);
window.open(""+linkURL+"", "", sFeatures);
}

Normally "scrollbars" has "=yes" or "=no" for example.
Your <a> element should also be:

Code:

<a href="javascript:openNewWin('/TestSite/jsp/showPhoto.jsp');">...</a>

in the source of the page, use view source to check, I think your quotes are missing.
Also try a simple window.open(linkURL) on its own.

--

Joe (Microsoft MVP - XML)

vinod_yadav1919 · August 5th, 2005, 11:27 AM

HIII,
Try this
hope u will get the solution
<script language="javascript">
function openNewWin() {
window.open(linkURL)
}

var linkURL = '/TestSites/showPhoto.html'
str ="<a href= \"javascript:openNewWin('+linkURL+')\">LoginHer e</a>";
document.write(str)
</script>

Cheers :)

vinod

jvanscha · August 5th, 2005, 11:45 AM

Thanks guys!

I tried your suggestions and I got it to work...
I guess I didnt need to pass the linkURL variable into the openNewWin() Function.

I removed the parameter, and it worked perfectly:

function openNewWin() {
var sFeatures = "scrollbars, top="+winTop+", left="+winLeft+", height="+winHeight+", width="+winWidth+"";
window.open(""+linkURL+"", "", sFeatures);
}

var linkURL = "/TestSite/jsp/showPhoto.jsp"
document.write('<tr><td align="center"><a href="javascript:openNewWin();">');
document.write('<IMG src="/TestSite/images/'+ photo +'" width="190"></a></td></tr>');

I think Joe was right, the quotes were getting screwed up somewhere.

Best Regards,

Josh

joefawcett · August 5th, 2005, 11:58 AM

Quote:

quote:I guess I didnt need to pass the linkURL variable into the openNewWin() Function.

That's because linkURL is global variable so the function can read it without it being a parameter.

Using javascript URLs is not a good idea anyway, it stops people without JavaScript using the site. Better to use this which degrades gracefully:

Code:

<a href="/TestSite/jsp/showPhoto.jsp" onclick="openNewWin(this.href); return false;">Show Photo</a>

Obviuosly though if you are using document.write users without JavaScript have had it anyway...
If you are using JSP you don't need document.write, why not produce the page on the server?

--

Joe (Microsoft MVP - XML)

jvanscha · August 5th, 2005, 12:32 PM

Joe,

The opener page is actually an HTML page with JavaScript. I guess I called it a JSP page in my original post; I think I'm retarded or something. My webapp is inside a firewalled intranet with locked workstation configurations and everyone has javascript enabled; So I don't need to worry about that for this application. I did change the anchor tag as you suggested though, that's much better form. Thanks for the advice and help.

Best Regards,
Josh