Not Implemented Error

Imar · May 20th, 2004, 11:38 AM

Well, you know what they say: if it ain't broken, don't fix it ;) Glad it's working.

However, you can optimize your code a bit. If all the setChecked* functions do is set the required item, you can make the function dynamic, so you only need one function instead of 20. Instead of passing in just the ID of the control, you can also pass in the indices of the array:

Code:

function setChecked(selvalue, first, second)
{
    if(ID[first][second] == 'Y')
    {
        document.getElementById(selvalue).selectedIndex = 0;
    }
    else
    {
        document.getElementById(selvalue).selectedIndex = 1;
    }
}

This way, you only need one method that you can call with different parameters:

Code:

onLoad="setChecked('opt3308', 0, 0);setChecked('opt3326', 0, 1);setChecked('opt3320', 1, 1); etc etc

I just made up the numbers I am passing to setChecked, but I am sure you get the idea.

Cheers,

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.
While typing this post, I was listening to: Soulfly (Universal Spirit Mix) by Soulfly (Track 16 from the album: Primitive) What's This?

Snib · May 20th, 2004, 11:43 AM

And if you REALLY want to save space, rename the function to c() or something :D

Snib

<><

fs22 · May 20th, 2004, 01:39 PM

Folks,

There is very little difference in each checked_ function. Here is one of them...

<script language="JavaScript">
function setCheckeda(selvalue)
{
    if(ID[0][2] == 'Y')
    {
        document.getElementById(selvalue).selectedIndex = 0;
    }
    else
    {
        document.getElementById(selvalue).selectedIndex = 1;
    }
}
</script>

The only difference is the ID array numbers change in each function because each yes/no select menu needs to be tied to a specific ID[#][#]. If there is a smoother. more dynamic way to do that...great. Let me know. But basically I have an array with like 18 values in each and each one needs to be tied to a select menu. By the way, this is a page that will be pulled locally...not across the web. It is not asp, which I would prefer, but unfortunately...it is not. And all the comment tags and mess was put in there by another user via dreamweaver who is a designer not a programmer. I just want to make the code work as smoothly as possible. Thanks for the assist.

Clay Hess

Imar · May 20th, 2004, 01:53 PM

Hi Clay,

If I understand your last post correctly, I think I already posted the "smoother, more dynamic way". Your setChecked should accept the numbers to index your array as parameters. Your onload code can then pass the required numbers into the setChecked method.

Cheers,

Imar
---------------------------------------
Imar Spaanjaars
Everyone is unique, except for me.

fs22 · May 20th, 2004, 03:10 PM

Imar,

Thanks a lot for the suggestion! That did make it smoother. I went down to one function and placed that in the head and then just passed the array variables. Again...thanks for the assist!

Clay Hess

a1call · December 9th, 2005, 11:06 AM

Hi,
I was getting the same error. It seems that it refers to the use of brackets.
onload = setChecked;
rather than
onload = setChecked('opt3308');
should eliminate the error. Try passing the
'opt3308'
some other way perhaps using a global variable.
This is to help out anyone else who might end up here with the same problem.