javascript "stop" syntax

crmpicco · August 19th, 2005, 10:52 AM

Code:

function unCheck(counter,type,cell)
{
    checked=false;
    for (x=0;x<counter;x++)
    {         
        eval("document.form."+type+""+x+".checked = false")
    }
    stop;
}

this code works, but i am getting a JS error:
"'stop' is undefined"

why is this?

www.crmpicco.co.uk
www.crmpicco.co.uk.tt
www.milklemonadechocolate.uk.tt
www.griswolds.uk.tt
www.piccosmini.co.uk.tt
www.morton.uk.tt

joefawcett · August 19th, 2005, 03:59 PM

Three things, firstly my golden rule of JavaScript: NEVER USE EVAL.
Secondly what is stop meant to do? It is not a JavaScript statement and the function is about to return anyway so you don't need it. Thirdly why pass in cell to the function if you don't use it?

Code:

function unCheck(counter, type)
{
  for (x = 0; x < counter; x++)
  {
    document.form[type + x].checked = false;
  }
}

--

Joe (Microsoft MVP - XML)

crmpicco · August 22nd, 2005, 08:26 AM

Code:

// Uncheck all boxes that have been previously checked
function unCheck(counter,type,cell)
{
    checked=false;
    for (x=0;x<counter;x++)
    {         
        eval("document.form."+type+""+x+".checked = false")
    }
    return false;
}

that works, why not use EVAL?

www.crmpicco.co.uk
www.crmpicco.co.uk.tt
www.milklemonadechocolate.uk.tt
www.griswolds.uk.tt
www.piccosmini.co.uk.tt
www.morton.uk.tt

joefawcett · August 22nd, 2005, 08:46 AM

Basically it's an incredible resource hog and totally unnecessary. See here for the full story:

http://blogs.msdn.com/ericlippert/ar.../01/53329.aspx

--

Joe (Microsoft MVP - XML)

crmpicco · September 14th, 2005, 05:55 AM

is there a quicker way to do this:

Code:

eval("df.pre"+i+".style.visibility = action");

www.crmpicco.co.uk
www.crmpicco.co.uk.tt
www.milklemonadechocolate.uk.tt
www.griswolds.uk.tt
www.piccosmini.co.uk.tt
www.morton.uk.tt

crmpicco · September 14th, 2005, 06:01 AM

Code:

function hideselect(action,uniquecount)
{
    //df = document.form

    for(i=0;i<uniquecount+1;i++)
    {
        // netfare1 drop-down menus to be hidden
        if(document.form.getElementByName("pre"+i+"")!=null)
        {
            eval("document.form.pre"+i+".style.visibility = action");
        }
        if(document.form.getElementByName("via1"+i+"")!=null)
        {
            eval("document.form.via1"+i+".style.visibility = action");
        }

        ...
        ...

        ...

I am getting a JS error at this line:

Code:

if(document.form.getElementByName("pre"+i+"")!=null)

Can anyone see the error?

www.crmpicco.co.uk
www.crmpicco.co.uk.tt
www.milklemonadechocolate.uk.tt
www.griswolds.uk.tt
www.piccosmini.co.uk.tt
www.morton.uk.tt